Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPedSA class cleanup & optimization #3656

Merged
merged 19 commits into from
Mar 1, 2025

Conversation

FileEX
Copy link
Contributor

@FileEX FileEX commented Aug 17, 2024

This PR is intended to clean up the CPedSA class.

  • Refactoring of CPedSA.cpp, CPedSA.h, and CPed.h according to the latest coding guidelines and C++ standards
  • Cleanup of the aforementioned files
  • Completion of missing fields in the CPedSAInterface class and cleanup of their types
  • Added classes for interfaces related to ped sounds
  • Minor optimization by reducing unnecessary operations and redundancies.

@Dutchman101
Copy link
Member

@FileEX Do you have any further plans (more changes/todo) or is it ready?

Either way, please resolve conflicts

@FileEX
Copy link
Contributor Author

FileEX commented Feb 16, 2025

@FileEX Do you have any further plans (more changes/todo) or is it ready?

Either way, please resolve conflicts

It's ready

@Dutchman101
Copy link
Member

Ok, then this will be tested on nightly during the upcoming testing phase in preparation for 1.6.1

@Dutchman101 Dutchman101 merged commit 2526a7d into multitheftauto:master Mar 1, 2025
6 checks passed
@FileEX FileEX deleted the refactor/CPedSA-cleanup branch March 1, 2025 23:55
@botder botder added this to the 1.6.1 milestone Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants