Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to toggle photos taken by ingame camera to be saved in documents folder (fixes #3542) #3667

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add setting to toggle photos taken by ingame camera to be saved in documents folder (fixes #3542) #3667

wants to merge 14 commits into from

Conversation

ffsPLASMA
Copy link
Contributor

Adds a new setting in video tab called "Save photos inside documents folder" which allows you to decide if you want to save photos taken by ingame camera to be saved in documents folder or not.

fixes #3542

grafik

@TracerDS
Copy link
Contributor

TracerDS commented Aug 21, 2024 •
edited
Loading

Would it save to %USERPROFILE%/Documents or MTA/screenshots?

@ffsPLASMA
Copy link
Contributor Author

ffsPLASMA commented Aug 21, 2024 •
edited
Loading

This is only related to the ingame camera taking photos. screenshots taken by pressing f12 are not affected.

@TracerDS
Copy link
Contributor

This is only related to the ingame camera taking photos. screenshots taken by pressing f12 are not affected.

I think it would be better to save them in screenshots folder.
Userprofile should not be trashed by screenshots from camera.

@ffsPLASMA
Copy link
Contributor Author

This is only related to the ingame camera taking photos. screenshots taken by pressing f12 are not affected.

I think it would be better to save them in screenshots folder. Userprofile should not be trashed by screenshots from camera.

The current behaviour is the ingame camera saves the photo to the userprofile documents folder. This PR allows this behaviour to be disabled so no screenshot is being saved to disk when taking one ingame.

@TheNormalnij
Copy link
Member

It doesn't look like video tab is right tab for this setting.
Maybe you need to use Advanced tab and change name for this setting,
I can't get what this setting do without your additional description

TracerDS
TracerDS suggested changes Aug 21, 2024
View reviewed changes
Client/core/CScreenShot.cpp Outdated Show resolved Hide resolved
Client/core/CSettings.cpp Outdated Show resolved Hide resolved
Client/core/CScreenShot.cpp Outdated Show resolved Hide resolved
Client/core/CScreenShot.cpp Outdated Show resolved Hide resolved
Client/core/CScreenShot.cpp Outdated Show resolved Hide resolved
@tederis tederis added the enhancement New feature or request label Aug 22, 2024
@ffsPLASMA
Copy link
Contributor Author

Added it to advanced tab with more fitting description

grafik

FileEX
FileEX approved these changes Oct 4, 2024
View reviewed changes
Client/core/CScreenShot.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fernando-A-Rocha Fernando-A-Rocha Fernando-A-Rocha approved these changes

@FileEX FileEX FileEX approved these changes

@tederis tederis tederis left review comments

@TheNormalnij TheNormalnij TheNormalnij left review comments

@TracerDS TracerDS TracerDS approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the possibility that the camera (weapon) does not create screenshots in a folder
6 participants
@ffsPLASMA @TracerDS @TheNormalnij @tederis @FileEX @Fernando-A-Rocha