Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding setVehicleNitroActivated server-side #3706

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Adding setVehicleNitroActivated server-side #3706

wants to merge 12 commits into from

Conversation

Proxy-99
Copy link
Contributor

@Proxy-99 Proxy-99 commented Sep 8, 2024 •
edited
Loading

part of #3703 help with #2726

@Proxy-99 Proxy-99 mentioned this pull request Sep 9, 2024
Open
1 task
FileEX
FileEX suggested changes Sep 9, 2024
View reviewed changes
Client/mods/deathmatch/logic/rpc/CVehicleRPCs.cpp Outdated Show resolved Hide resolved
Client/mods/deathmatch/logic/rpc/CVehicleRPCs.cpp Outdated Show resolved Hide resolved
@Proxy-99 Proxy-99 requested a review from FileEX September 9, 2024 21:56
FileEX
FileEX approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@FileEX FileEX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add a condition to CLuaVehicleDefs::SetVehicleNitroActivated in the future whether the new state is different from the previous one (When IsVehicleNitroActivated will be available)

if (state == IsVehicleNitroActivated(vehicle))
    return false;

@tederis tederis added the enhancement New feature or request label Sep 10, 2024
tederis
tederis reviewed Sep 12, 2024
View reviewed changes
Shared/sdk/net/rpc_enums.h Outdated Show resolved Hide resolved
@TracerDS TracerDS mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tederis tederis tederis left review comments

@TracerDS TracerDS TracerDS approved these changes

@FileEX FileEX FileEX approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Proxy-99 @tederis @FileEX @TracerDS