HUD Customization #3836

FileEX · 2024-11-01T22:56:19Z

This PR adds customization for the default HUD in GTA. Eventually, all components are intended to be modifiable. Currently, the PR is in progress, and the following properties are available:

Position
Size
Bar fill colors
Black border
Percentage value
The HP value at which the health bar flashes

Syntax

bool setPlayerHudComponentProperty(string component, string property, mixed value)
mixed getPlayerHudComponentProperty(string component, string property)
bool resetPlayerHudComponentProperty(string component, string property)

I also plan to create a HUD visualization in the settings where changes will be possible. However, I think that will be part of a separate PR.

With this PR, it will also be possible to easily fix issues like #3807 without the need to patch values in memory.

setPlayerHudComponentProperty('health', 'fillColor', tocolor(50, 168, 82, 255));
setPlayerHudComponentProperty('breath', 'fillColor', tocolor(167, 189, 58, 255));
setPlayerHudComponentProperty('armour', 'fillColor', tocolor(53, 130, 171, 255));

setPlayerHudComponentProperty('armour', 'drawPercentage', true);

setPlayerHudComponentProperty('health', 'position', 300, 200);
setPlayerHudComponentProperty('health', 'size', 100, 20);

setPlayerHudComponentProperty('breath', 'position', 300, 240);
setPlayerHudComponentProperty('armour', 'position', 300, 280);

setPlayerHudComponentProperty('armour', 'size', 300, 20);

Fernando-A-Rocha · 2024-11-02T01:21:20Z

Nice, what about #3444 ?

Proxy-99 · 2024-11-02T09:14:16Z

Nice, what about #3444 ?

this is a patch for wide screens has nothing to do with customization

Fernando-A-Rocha · 2024-11-02T10:03:25Z

Nice, what about #3444 ?

this is a patch for wide screens has nothing to do with customization

This PR alters HUD component sizes, won't it conflict with wide screen HUD sizing PR?

Proxy-99 · 2024-11-02T10:20:10Z

Nice, what about #3444 ?

this is a patch for wide screens has nothing to do with customization

This PR alters HUD component sizes, won't it conflict with wide screen HUD sizing PR?

this is normal but we compare conflicts according to multitheftauto:master rely on which pr will be merged first other pr has to adjuct to the new changes

TracerDS · 2024-11-02T10:17:33Z

Client/game_sa/CGameSA.h

@@ -190,6 +190,7 @@ class CGameSA : public CGame
    int32_t GetCountOfAllFileIDs() { return (*(char**)(0x5B8AFA + 2) - *(char**)(0x5B8B08 + 6)) / sizeof(CStreamingInfo); }

    DWORD GetSystemTime() { return *(DWORD*)0xB7CB84; } // CTimer::m_snTimeInMilliseconds
+    int   GetSystemFrameCounter() { return *(int*)0xB7CB4C; } // CTimer::m_FrameCounter


TracerDS · 2024-11-02T10:18:59Z

Client/game_sa/CHudSA.cpp

+    float  totalWidth = ((useCustomSize ? componentProperties.hpBar.bar.placement.customWidth : componentProperties.hpBar.bar.placement.width) * maxHealth) / statModifier;
+
+    // call CSprite2d::DrawBarChart
+    ((void(__cdecl*)(float, float, std::uint16_t, std::uint32_t, float, bool, bool, bool, RwColor, RwColor))FUNC_CSprite2d_DrawBarChart)(useCustomPosition ? componentProperties.hpBar.bar.placement.customX : (useCustomSize ? componentProperties.hpBar.bar.placement.customWidth : componentProperties.hpBar.bar.placement.width) - totalWidth + x, useCustomPosition ? componentProperties.hpBar.bar.placement.customY : y, static_cast<std::uint16_t>(totalWidth), static_cast<std::uint32_t>(useCustomSize ? componentProperties.hpBar.bar.placement.customHeight : componentProperties.hpBar.bar.placement.height), playerPed->GetHealth() * 100.0f / maxHealth, false, componentProperties.hpBar.bar.drawPercentage, componentProperties.hpBar.bar.drawBlackBorder, componentProperties.hpBar.bar.fillColor, COLOR_BLACK);


maybe separate these conditional arguments?

TracerDS · 2024-11-02T10:19:12Z

Client/game_sa/CHudSA.cpp

+    bool useCustomSize = componentProperties.breathBar.bar.placement.useCustomSize;
+
+    // call CSprite2d::DrawBarChart
+    ((void(__cdecl*)(float, float, std::uint16_t, std::uint32_t, float, bool, bool, bool, RwColor, RwColor))FUNC_CSprite2d_DrawBarChart)(useCustomPosition ? componentProperties.breathBar.bar.placement.customX : x, useCustomPosition ? componentProperties.breathBar.bar.placement.customY : y, static_cast<std::uint16_t>(useCustomSize ? componentProperties.breathBar.bar.placement.customWidth : componentProperties.breathBar.bar.placement.width), static_cast<std::uint32_t>(useCustomSize ? componentProperties.breathBar.bar.placement.customHeight : componentProperties.breathBar.bar.placement.height), playerPed->GetOxygenLevel() / statModifier * 100.0f, false, componentProperties.breathBar.bar.drawPercentage, componentProperties.breathBar.bar.drawBlackBorder, componentProperties.breathBar.bar.fillColor, COLOR_BLACK);


TracerDS · 2024-11-02T10:19:40Z

Client/game_sa/CHudSA.cpp

+    ((void(__cdecl*)(float, float, std::uint16_t, std::uint32_t, float, bool, bool, bool, RwColor, RwColor))FUNC_CSprite2d_DrawBarChart)(useCustomPosition ? componentProperties.armorBar.bar.placement.customX : x, useCustomPosition ? componentProperties.armorBar.bar.placement.customY : y, static_cast<std::uint16_t>(useCustomSize ? componentProperties.armorBar.bar.placement.customWidth : componentProperties.armorBar.bar.placement.width), static_cast<std::uint32_t>(useCustomSize ? componentProperties.armorBar.bar.placement.customHeight : componentProperties.armorBar.bar.placement.height), playerPed->GetArmor() / static_cast<float>(pGame->GetPlayerInfo()->GetMaxArmor()) * 100.0f, false, componentProperties.armorBar.bar.drawPercentage, componentProperties.armorBar.bar.drawBlackBorder, componentProperties.armorBar.bar.fillColor, COLOR_BLACK);
+}
+
+static void _declspec(naked) HOOK_RenderHudBar()


can you make that function non naked?

TracerDS · 2024-11-02T10:21:05Z

Client/sdk/game/CPlayerInfo.h

+    virtual std::uint8_t GetMaxHealth() = 0;
+    virtual std::uint8_t GetMaxArmor() = 0;


const and/or noexcept?

tederis · 2024-12-18T08:20:57Z

Client/mods/deathmatch/logic/luadefs/CLuaPlayerDefs.cpp

+                    if (!std::holds_alternative<float>(value))
+                        return false;
+
+                    g_pGame->GetHud()->SetComponentBarColor(component, std::get<float>(value));


Why do we need to store a color as floaing point number?

Hud customization

9437a18

FileEX marked this pull request as draft November 1, 2024 22:58

TracerDS suggested changes Nov 2, 2024

View reviewed changes

Merge branch 'master' into feature/hud-customiztion

9d348ea

tederis reviewed Dec 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HUD Customization #3836

HUD Customization #3836

FileEX commented Nov 1, 2024 •

edited

Loading

Fernando-A-Rocha commented Nov 2, 2024

Proxy-99 commented Nov 2, 2024

Fernando-A-Rocha commented Nov 2, 2024

Proxy-99 commented Nov 2, 2024 •

edited

Loading

TracerDS Nov 2, 2024

TracerDS Nov 2, 2024

TracerDS Nov 2, 2024

TracerDS Nov 2, 2024

TracerDS Nov 2, 2024

tederis Dec 18, 2024

		virtual std::uint8_t GetMaxHealth() = 0;
		virtual std::uint8_t GetMaxArmor() = 0;

HUD Customization #3836

Are you sure you want to change the base?

HUD Customization #3836

Conversation

FileEX commented Nov 1, 2024 • edited Loading

Syntax

Fernando-A-Rocha commented Nov 2, 2024

Proxy-99 commented Nov 2, 2024

Fernando-A-Rocha commented Nov 2, 2024

Proxy-99 commented Nov 2, 2024 • edited Loading

TracerDS Nov 2, 2024

Choose a reason for hiding this comment

TracerDS Nov 2, 2024

Choose a reason for hiding this comment

TracerDS Nov 2, 2024

Choose a reason for hiding this comment

TracerDS Nov 2, 2024

Choose a reason for hiding this comment

TracerDS Nov 2, 2024

Choose a reason for hiding this comment

tederis Dec 18, 2024

Choose a reason for hiding this comment

FileEX commented Nov 1, 2024 •

edited

Loading

Proxy-99 commented Nov 2, 2024 •

edited

Loading