Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setVehicleDirtLevel #3837

Merged
merged 6 commits into from
Dec 14, 2024
Merged

Fix setVehicleDirtLevel #3837

merged 6 commits into from
Dec 14, 2024

Conversation

FileEX
Copy link
Contributor

@FileEX FileEX commented Nov 2, 2024

This PR fixes the long-standing non-functional setVehicleDirtLevel function. The code is based on the source code of SilentPatch by CookiePL, also known as Silent.

image
image

@Fernando-A-Rocha
Copy link
Contributor

Woww!! Thank you for this. Finally we can start having the amazing GTA:SA fixes the community has created over time, on MTA

@Fernando-A-Rocha
Copy link
Contributor

Fixes #3233

@PlatinMTA
Copy link
Contributor

Could we also get a getVehicleDirtLevel? Just because

@FileEX
Copy link
Contributor Author

FileEX commented Nov 2, 2024

Could we also get a getVehicleDirtLevel? Just because

Yeah but in separate PR

@Fernando-A-Rocha
Copy link
Contributor

Could we also get a getVehicleDirtLevel? Just because

Makes sense to have. For example in a custom car wash system where you calculate the price based on the dirt

@TheNormalnij TheNormalnij added enhancement New feature or request feedback Further information is requested bugfix Solution to a bug of any kind labels Nov 14, 2024
@FileEX @TheNormalnij
Update Client/game_sa/CModelInfoSA.h
be0fa46 
Review

Co-authored-by: Uladzislau Nikalayevich <[email protected]>
@lopezloo
Copy link
Member

Does it fix setVehicleDirtLevel function only or it makes vehicles to gain dirt over time too?

@FileEX
Copy link
Contributor Author

FileEX commented Nov 17, 2024

Does it fix setVehicleDirtLevel function only or it makes vehicles to gain dirt over time too?

Probably both cases

@Dutchman101
Copy link
Member

Nice, ty

@Dutchman101 Dutchman101 merged commit 81218c7 into multitheftauto:master Dec 14, 2024
6 checks passed
@FileEX FileEX deleted the bugfix/vehicle-dirt-level branch December 14, 2024 12:04
@Jator-1
Copy link

Jator-1 commented Dec 21, 2024

This PR probably broke backward compatibility of some shaders. Also after recent update (ver. 22829) texture of vehiclegrunge256 are not correctly displayed on vehicles and components.

Vehicle components probably use now different materials or texture and they are not shown up on shader_tex_names (displayed only on 'chassis' of ZR-350, missing on doors, bonnet, rear bumper, extra1 and whole Premier)
image
image

ver. 22789 - shader works perfectly fine
image (1)
ver. 22829 - shader does not work on vehicle components as bonnet and boot resulting in different shades of paint
image

@ZbyK77 ZbyK77 mentioned this pull request Dec 21, 2024
Closed
1 task
Dutchman101 added a commit that referenced this pull request Dec 21, 2024
@Dutchman101
Revert "Fix setVehicleDirtLevel (#3837)"
ff84958 
This reverts commit 81218c7 because of the bugs it caused: see issues #3893 and #3894
@FileEX FileEX restored the bugfix/vehicle-dirt-level branch December 28, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheNormalnij TheNormalnij TheNormalnij left review comments

@TracerDS TracerDS TracerDS requested changes

Assignees
No one assigned
Labels
bugfix Solution to a bug of any kind enhancement New feature or request feedback Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@FileEX @Fernando-A-Rocha @PlatinMTA @lopezloo @Dutchman101 @Jator-1 @TheNormalnij @TracerDS