Check before sending to prevent crash because of #3866 #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks if the player exists and only then performs the next check which applies to the BitStream version
|
won't work |
Comment on lines
-10865
to
-10869
| if (pPlayer->CanBitStream(eBitStreamVersion::FixSyncerDistance)) | ||
| if (pPlayer) | ||
| { | ||
| BitStream.pBitStream->Write(g_TickRateSettings.iPedSyncerDistance); | ||
| BitStream.pBitStream->Write(g_TickRateSettings.iUnoccupiedVehicleSyncerDistance); | ||
| } |
There was a problem hiding this comment.
You need min client version check here.
The new client always expects all data.
There was a problem hiding this comment.
Well, thanks for reporting the issue, but could you please elaborate on it and how exactly it should be solved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if the player exists and only then performs the next check which applies to the BitStream version.
Closes #3882.