Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relayed v3 esdt transfer #6775

Merged

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Feb 4, 2025
@sstanculeanu sstanculeanu changed the base branch from master to rc/spica-patch-relayedv3-fix February 4, 2025 12:41
@multiversx multiversx deleted a comment from github-actions bot Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 18c2624e5b496934bb8fe222c3ed73767571523d
  • Current Branch: fix_relayed_v3_esdt_transfer
  • mx-chain-go Target Branch: rc/spica-patch-relayedv3-fix
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 04022025-131812
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

github-actions bot commented Feb 4, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: ff177346a9a88f9c3db8ba1b217c48070f44d107
  • Current Branch: fix_relayed_v3_esdt_transfer
  • mx-chain-go Target Branch: rc/spica-patch-relayedv3-fix
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 04022025-132220
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@andreibancioiu andreibancioiu self-requested a review February 4, 2025 14:03
andreibancioiu
andreibancioiu previously approved these changes Feb 4, 2025
func (sc *scProcessor) processSCPayment(
tx data.TransactionHandler,
acntSnd state.UserAccountHandler,
acntRcv state.UserAccountHandler,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes we say acntRcv, and sometimes acntDst (tiny inconsistency).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to acntDst

@sstanculeanu
Copy link
Collaborator Author

Run Tests:
mx-chain-testing-suite: main
mx-chain-simulator-go: main

Copy link

github-actions bot commented Feb 5, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 1bf6d6d3ad69fb8c2344e76f6d663deed547bbe5
  • Current Branch: fix_relayed_v3_esdt_transfer
  • mx-chain-go Target Branch: rc/spica-patch-relayedv3-fix
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05022025-112105
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@sasurobert sasurobert self-requested a review February 5, 2025 11:37
Copy link
Collaborator

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.8.9-dev-config-373fab6fb9 -> fix_relayed_v3_esdt_transf-1bf6d6d3ad

--- Specific errors ---

block hash does not match 1862
wrong nonce in block 704
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 1318
Nr. of new ERRORS: 0
Nr. of new WARNS: 727
Nr. of PANICS: 0
Nodes with panic: []

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

@sstanculeanu sstanculeanu merged commit 5419e1d into rc/spica-patch-relayedv3-fix Feb 6, 2025
8 checks passed
@sstanculeanu sstanculeanu deleted the fix_relayed_v3_esdt_transfer branch February 6, 2025 11:25
@sstanculeanu sstanculeanu restored the fix_relayed_v3_esdt_transfer branch February 6, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants