Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log path #28

Closed
wants to merge 1 commit into from
Closed

fix log path #28

wants to merge 1 commit into from

Conversation

porjo
Copy link
Contributor

@porjo porjo commented Aug 27, 2018

Currently if --datadir is set to something other than default with --log not explicitly set, log gets written to ~/.grumble/grumble.log even though the cli documentation says it should be written to $DATADIR/grumble.log.

This fixes that.

@rubenseyer
Copy link
Contributor

Changes to how these options are handled in #26 fixes this. Sorry for not making this more clear in the pull request.

@porjo
Copy link
Contributor Author

porjo commented Aug 28, 2018

@rubenseyer ok, no problem. I'll let a maintainer close this.

@ghost
Copy link

ghost commented Sep 1, 2018

Included in #26

@ghost ghost closed this Sep 1, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants