Add heading hover-id-links #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For headings with an id attribute add anchors that show on hover and are clickable. They link to the #id hash so clicking them will jump to that headline and update the address bar, and copying their link will copy a link to that page and heading.
This was previously implemented in ad5f7e1. Now we have a better mechanism. Only with JavaScript but for all headings with id attributes.
Krzmbrzl
approved these changes
Oct 31, 2020
davidebeatrici
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For headings with an id attribute add anchors that show on hover and are clickable.
They link to the #id hash so clicking them will jump to that headline and update the address bar,
and copying their link will copy a link to that page and heading.
The anchor will show on hover anywhere on the heading (not just to the left of it where the anchor link is).
This also does not break our 1.3.0 release notes blog post which had anchors at the end of them.
The unicode link character could be replaced with an icon. A blue color to match our hyperlinks could be good. We could also change that later though.
This change is especially useful for longer blog posts like release announcements, and will be useful for longer content pages, especially documentation.
Implements #43.