Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(user): Add Settings Storage Location #194

Merged
merged 1 commit into from
Jul 15, 2023
Merged

docs(user): Add Settings Storage Location #194

merged 1 commit into from
Jul 15, 2023

Conversation

Kissaki
Copy link
Member

@Kissaki Kissaki commented Jul 2, 2023

@Kissaki Kissaki mentioned this pull request Jul 2, 2023
Closed
@Krzmbrzl
Copy link
Member

Krzmbrzl commented Jul 3, 2023 •
edited
Loading

This should include the settings location for 1.5 onwards, where we always save the settings as a JSON file, regardless of the OS we're on.
I just don't know the locations of other OS than linux by-heart right now.
https://github.com/mumble-voip/mumble/blob/e828ef0458927b21df590f84efce051abd33b2b0/src/mumble/Settings.cpp#L1273-L1273

or rather

https://github.com/mumble-voip/mumble/blob/e828ef0458927b21df590f84efce051abd33b2b0/src/mumble/Settings.cpp#L1310-L1318

@Kissaki Kissaki mentioned this pull request Jul 15, 2023
Open
@Kissaki
Copy link
Member Author

Kissaki commented Jul 15, 2023

I am merging as is, as this state is verifiable and 1.5 is not stable released yet (currently RC).

I created #195 for adding the 1.5 info.

@Kissaki Kissaki merged commit 01dfd5e into master Jul 15, 2023
@Kissaki Kissaki deleted the docs/conf-location branch July 15, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidebeatrici davidebeatrici Awaiting requested review from davidebeatrici

@Krzmbrzl Krzmbrzl Awaiting requested review from Krzmbrzl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kissaki @Krzmbrzl