Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: /people redesign #261

Merged
merged 3 commits into from
Dec 17, 2024
Merged

style: /people redesign #261

merged 3 commits into from
Dec 17, 2024

Conversation

zeucapua
Copy link
Collaborator

@zeucapua zeucapua commented Dec 10, 2024 •
edited
Loading

WIP
Related to #259

image

@zeucapua zeucapua requested a review from erlend-sh December 10, 2024 21:14
@erlend-sh
Copy link
Contributor

Looking good!

My only note is that I feel even more strongly now that we should limit displayed tags to just three, I.e. the first three listed in ones profile.

@erlend-sh
Copy link
Contributor

Actually, I think we should show all of these after the avatar:

  1. Name (real or nick)
  2. domain (username)
  3. tags

So I for instance would be:

[avatar]
Erlend Sogge Heggen (large)
erlend.sh (small)
open-source, agency, something (medium)

@zicklag zicklag added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 93ae95c Dec 17, 2024
1 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erlend-sh erlend-sh erlend-sh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeucapua @erlend-sh @zicklag