Fix: Reauthenticate with SiriusXM when playing a station #1789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address music-assistant/hass-music-assistant#3165
As stated on the issue:
I think the problem is that we authenticate with SiriusXM when the server starts up so that we can confirm authentication details, and load the list of channels. However, the sxm session expires frequently. By the time the user attempts to play a station, there's a decent chance that the session is expired. The
sxm-client
will attempt to re-authenticate automatically, but by the time this happens, there's a decent chance ffmpeg will raise aTimeoutError
.This patch makes it so that the code preemptively attempts to re-authenticate with SiriusXM before handing over the m3u8 playlist, ensuring that there is a valid session. It's possible this will cause a slight delay to start the feed, but in my (limited) testing, this was fine, and still preferable to the
TimeoutError
being raised.