Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding docker build #42

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TooDissing
Copy link
Contributor

@TooDissing TooDissing commented Jun 3, 2022

Fixes #41.

Adding a small docker container that can build the cli target.

The resulting bin also runs, but fails (on my machine) when trying to access ALSA. This makes sense as I am running on macOS.

TODO: Hope to be able to test on a linux within a few day, to validate that audio also works.

@feelfreelinux
Copy link
Member

Looks good, will hold on with merging until I test it out on my machine. Not sure how audio would work without forwarding /dev/snd.

@TooDissing
Copy link
Contributor Author

Looks good, will hold on with merging until I test it out on my machine. Not sure how audio would work without forwarding /dev/snd.

I guess it won't.

But something you can choose to do, when starting the container.
We can create a docker-compose.yaml file to make this part easier.

@feelfreelinux
Copy link
Member

Looks good, will hold on with merging until I test it out on my machine. Not sure how audio would work without forwarding /dev/snd.

I guess it won't.

But something you can choose to do, when starting the container. We can create a docker-compose.yaml file to make this part easier.

Actually, my bad, now i see that you point to pulse's socket. Maybe this would also work after installing pulse on macos?

@TooDissing
Copy link
Contributor Author

Looks good, will hold on with merging until I test it out on my machine. Not sure how audio would work without forwarding /dev/snd.

I guess it won't.
But something you can choose to do, when starting the container. We can create a docker-compose.yaml file to make this part easier.

Actually, my bad, now i see that you point to pulse's socket. Maybe this would also work after installing pulse on macos?

Basically just took the config from the docker image in the cspot project. Main purpose was to be able to build the CLI target.
Will convert to draft and do additional testing :-)

@TooDissing TooDissing marked this pull request as draft June 6, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Undefined symbols for architecture x86_64 when building CLI target
2 participants