Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add range thumb slot #1013

Merged
merged 4 commits into from
Feb 13, 2025
Merged

feat: add range thumb slot #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae8e3b1
feat: add thumb slot
luwes Oct 24, 2024
d89c2cb
docs: add thumb slot example
luwes Oct 28, 2024
ebe4cd4
fix: remove default styles for slotted thumb
luwes Nov 5, 2024
ed6e25c
fix: use translate to center thumb
luwes Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions docs/src/pages/docs/en/components/media-time-range.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,25 @@ Set the `preview` slot to an empty element to remove the default preview element
</media-controller>`}
/>

## Thumb slot

<SandpackContainer
editorHeight={330}
html={`<media-controller>
<video
playsinline muted crossorigin
slot="media"
src="https://stream.mux.com/A3VXy02VoUinw01pwyomEO3bHnG4P32xzV7u1j1FSzjNg/low.mp4"
></video>
<media-control-bar>
<media-time-range>
<svg slot="thumb">
<circle fill="#df2c2c" cx="5" cy="5" r="5"/>
</svg>
</media-time-range>
</media-control-bar>
</media-controller>`}
/>


## Styling
Expand Down
24 changes: 16 additions & 8 deletions src/js/media-chrome-range.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,22 +172,26 @@ template.innerHTML = /*html*/ `
}
}

#thumb {
#thumb,
::slotted([slot=thumb]) {
width: var(--media-range-thumb-width, 10px);
height: var(--media-range-thumb-height, 10px);
margin-left: calc(var(--media-range-thumb-width, 10px) / -2);
border: var(--media-range-thumb-border, none);
border-radius: var(--media-range-thumb-border-radius, 10px);
background: var(--media-range-thumb-background, var(--media-primary-color, rgb(238 238 238)));
box-shadow: var(--media-range-thumb-box-shadow, 1px 1px 1px transparent);
transition: var(--media-range-thumb-transition);
transform: var(--media-range-thumb-transform, none);
opacity: var(--media-range-thumb-opacity, 1);
translate: -50%;
position: absolute;
left: 0;
cursor: pointer;
}

#thumb {
border-radius: var(--media-range-thumb-border-radius, 10px);
background: var(--media-range-thumb-background, var(--media-primary-color, rgb(238 238 238)));
box-shadow: var(--media-range-thumb-box-shadow, 1px 1px 1px transparent);
border: var(--media-range-thumb-border, none);
}

:host([disabled]) #thumb {
background-color: #777;
}
Expand Down Expand Up @@ -232,7 +236,9 @@ template.innerHTML = /*html*/ `
<div id="pointer"></div>
<div id="progress" part="progress"></div>
</div>
<div id="thumb" part="thumb"></div>
<slot name="thumb">
<div id="thumb" part="thumb"></div>
</slot>
<svg id="segments"><clipPath id="segments-clipping"></clipPath></svg>
</div>
<input id="range" type="range" min="0" max="1" step="any" value="0">
Expand All @@ -243,6 +249,8 @@ template.innerHTML = /*html*/ `
/**
* @extends {HTMLElement}
*
* @slot thumb - The thumb element to use for the range.
*
* @attr {boolean} disabled - The Boolean disabled attribute makes the element not mutable or focusable.
* @attr {string} mediacontroller - The element `id` of the media controller to connect to (if not nested within).
*
Expand Down Expand Up @@ -386,7 +394,7 @@ class MediaChromeRange extends globalThis.HTMLElement {

this.#cssRules.pointer = getOrInsertCSSRule(this.shadowRoot, '#pointer');
this.#cssRules.progress = getOrInsertCSSRule(this.shadowRoot, '#progress');
this.#cssRules.thumb = getOrInsertCSSRule(this.shadowRoot, '#thumb');
this.#cssRules.thumb = getOrInsertCSSRule(this.shadowRoot, '#thumb, ::slotted([slot="thumb"])');
this.#cssRules.activeSegment = getOrInsertCSSRule(
this.shadowRoot,
'#segments-clipping rect:nth-child(0)'
Expand Down