Etch-a-sketch theme #454
Open
Etch-a-sketch theme #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save point Save point Save point Save point
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
heff
commented
Jan 27, 2023
| if (mediaControllerId) { | ||
| const mediaControllerEl = document.getElementById(mediaControllerId); | ||
| mediaControllerEl?.associateElement?.(this); | ||
| const rootNode = this.getRootNode(); |
There was a problem hiding this comment.
Trying to remember if there's any specific downsides to getRootNode. The TS parser at least doesn't like it when trying to use properties on it, so it needs to be ignored.
There was a problem hiding this comment.
we'll need to replace document.getElementById with this.getRootNode().getElementById for themes to work nicely with a decoupled media controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple implementation.
+Had to fix the media-controller attribute in chrome-button so it can work inside a shadow dom. Should be applied (in a followup) to other components.
Goals for a more advanced one (later PRs):