feat: use Typescript in custom-media-element #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
luwes
force-pushed
the
ts-custom-media
branch
from
cca06ab
to
447e778
Compare
cjpillsbury
approved these changes
Nov 25, 2024
| ], | ||
| "type": "module", | ||
| "main": "custom-media-element.js", | ||
| "types": "custom-media-element.d.ts", | ||
| "main": "dist/custom-media-element.js", |
There was a problem hiding this comment.
this will have ripple effects on CDN usage, right? do we need to account for that anywhere (in our owned projects, docs, comms, elsewhere)?
There was a problem hiding this comment.
good call. I think it's quite rare it's used via CDN. maybe for some examples and we tend to use the alias https://cdn.jsdelivr.net/npm/custom-media-element/+esm
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's easier to keep the type definitions up to date