-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qstash implementation #135
Open
rozig
wants to merge
3
commits into
main
Choose a base branch
from
async-webhook-processing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import { | ||
sendSlackAssetReady, | ||
sendSlackAutoDeleteMessage, | ||
} from './slack-notifier'; | ||
import { getScores as moderationGoogle } from './moderation-google'; | ||
import { getScores as moderationHive } from './moderation-hive'; | ||
import { autoDelete } from './moderation-action'; | ||
|
||
type WebhookRequestBody = { | ||
type: string; | ||
object: any; | ||
id: string; | ||
environment: any; | ||
data: any; | ||
playback_ids?: any[]; | ||
duration: number; | ||
created_at: string; | ||
accessor_source: string; | ||
accessor: string; | ||
request_id: string; | ||
} | ||
|
||
export async function processMuxWebhook(data: WebhookRequestBody): Promise<boolean> { | ||
const assetId = data.id; | ||
const playbackId = | ||
data.playback_ids && data.playback_ids[0] && data.playback_ids[0].id; | ||
const duration = data.duration; | ||
|
||
const googleScores = await moderationGoogle({ playbackId, duration }); | ||
const hiveScores = await moderationHive({ playbackId, duration }); | ||
|
||
const didAutoDelete = hiveScores | ||
? await autoDelete({ assetId, playbackId, hiveScores }) | ||
: false; | ||
|
||
if (didAutoDelete) { | ||
await sendSlackAutoDeleteMessage({ assetId, duration, hiveScores }); | ||
console.log('Auto deleted this asset because it was bad'); | ||
} else { | ||
await sendSlackAssetReady({ | ||
assetId, | ||
playbackId, | ||
duration, | ||
googleScores, | ||
hiveScores, | ||
}); | ||
console.log('Notified myself about this'); | ||
} | ||
return true; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import { NextApiRequest, NextApiResponse } from 'next'; | ||
import { processMuxWebhook } from '../../../lib/mux-webhook-processor'; | ||
import { verifySignature } from '@upstash/qstash/nextjs'; | ||
|
||
async function qstashWebhookHandler( | ||
req: NextApiRequest, | ||
res: NextApiResponse | ||
): Promise<void> { | ||
const { method, body } = req; | ||
|
||
switch (method) { | ||
case 'POST': { | ||
try { | ||
await processMuxWebhook(body); | ||
res.json({ message: 'Success' }); | ||
} catch (e) { | ||
res.statusCode = 500; | ||
console.error('Request error', e); // eslint-disable-line no-console | ||
res.json({ error: 'Error handling webhook' }); | ||
} | ||
break; | ||
} | ||
default: | ||
res.setHeader('Allow', ['POST']); | ||
res.status(405).end(`Method ${method} Not Allowed`); | ||
} | ||
} | ||
|
||
export const config = { | ||
api: { | ||
bodyParser: false, | ||
}, | ||
}; | ||
|
||
// If QStash signing_keys are not defined in the env file, then it will respond back with error without processing the job | ||
export default verifySignature(qstashWebhookHandler); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a place where I can get all available fields of the webhook request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been some work on this recently by techops team, ask in #devex-dev channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at the
spec/webhook/samples
directory in this PR: https://github.com/muxinc/openapi-specification/pull/181There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jaredsmith :)