Skip to content

Commit

Permalink
CI: downgrade from macos-12, drop test-gotip
Browse files Browse the repository at this point in the history
Per rogpeppe#200, macos-12 can cause sporadic `signal: killed` testscript
failures, and we have started seeing them in some jobs within
go-internal itself as well. Downgrade to macos-11 for now,
like we've done in other projects, as we still don't know the cause.

Also drop test-gotip; we haven't been keeping it up to date for a while
now, so it's clearly not needed at the moment. If we want to ensure that
go-internal works on new major versions of Go before they are released,
using the beta or RC releases seems like a better and easier approach.
  • Loading branch information
mvdan committed Mar 22, 2023
1 parent 00e5e28 commit bee8416
Showing 1 changed file with 1 addition and 28 deletions.
29 changes: 1 addition & 28 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- '1.19.x'
os:
- ubuntu-latest
- macos-latest
- macos-11
- windows-latest
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -38,30 +38,3 @@ jobs:
test -z "$(gofmt -d .)" || (gofmt -d . && false)
test -z "$(git status --porcelain)" || (git status; git diff && false)
test-gotip:
runs-on: ubuntu-latest
continue-on-error: true # master breaks sometimes
steps:
- name: Install Go
env:
GO_COMMIT: 2cfbef438049fd4c3f73d1562773ad1f93900897 # 2022-06-09
run: |
cd $HOME
mkdir $HOME/gotip
cd $HOME/gotip
wget -O gotip.tar.gz https://go.googlesource.com/go/+archive/${GO_COMMIT}.tar.gz
tar -xf gotip.tar.gz
echo "devel go1.19-${GO_COMMIT}" >VERSION
cd src
./make.bash
echo "GOROOT=$HOME/gotip" >>$GITHUB_ENV
echo "$HOME/gotip/bin" >>$GITHUB_PATH
- name: Checkout code
uses: actions/checkout@v3
- name: Test
run: |
go version
go test ./...

0 comments on commit bee8416

Please sign in to comment.