interp: improve method signature #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
reviewed
Jan 2, 2025
ccoVeille
force-pushed
the
mapfile-split
branch
from
b3d96ed to
8da41f0
Compare
ccoVeille
changed the title
|
I just did |
|
The changes look the same to me. |
this is a zero code changes. The signature was already the right one. We are just using an alias, that will make things clearer.
ccoVeille
force-pushed
the
mapfile-split
branch
from
8da41f0 to
04198cc
Compare
|
My bad, it's OK now |
mvdan
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a zero code changes. The signature was already the right one.
We are just using an alias, that will make things clearer.