Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add custom blend bg #58

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix: add custom blend bg #58

merged 2 commits into from
Jun 6, 2024

Conversation

adriankarlen
Copy link
Contributor

I noticed that when using a transparent bg in neovim the blend function blends a bit weird as the Normal bg is set to "none". To fix this I wanted to add an optional color bg prop that can be used when blending.

Without custom bg

Screenshot 2024-06-05 103400

With custom bg

Screenshot 2024-06-05 103436

adds the ability to set a custom blend bg
@zahimeen
Copy link
Contributor

zahimeen commented Jun 5, 2024

honestly, i am unsure why this plugin makes its own blend function when the vim.api.nvim_set_hl has a blend parameter. check :help nvim_set_hl

@mvllow
Copy link
Owner

mvllow commented Jun 6, 2024

Thank you, this seems to work great :)

@zahimeen I have not had luck using the builtin blend. We use it for our Rosé Pine theme but still implement the logic ourselves because it didn't appear to do anything. Happy to revisit in the future. I'm currently (slowly) rewriting modes to be simpler overall.

@mvllow mvllow merged commit 326cff3 into mvllow:main Jun 6, 2024
@zahimeen
Copy link
Contributor

zahimeen commented Jun 7, 2024

Thank you, this seems to work great :)

@zahimeen I have not had luck using the builtin blend. We use it for our Rosé Pine theme but still implement the logic ourselves because it didn't appear to do anything. Happy to revisit in the future. I'm currently (slowly) rewriting modes to be simpler overall.

All good mate! Honestly, I have barely touched it myself and not sure about its functionality overall. The only case in which I have used it is from the Rosé Pine recipes for the status line. Anyways, good luck on the rewrite. There is a possibility I may have started my own rewrite of this plugin as well...

I love this plugin and your theme!

@mvllow
Copy link
Owner

mvllow commented Jun 9, 2024

My current rewrite progress is being tracked in #59

Happy to receive any feedback there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants