Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mvr schema #107

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Mvr schema #107

wants to merge 39 commits into from

Conversation

moritzstaffel
Copy link
Contributor

No description provided.

@petrvanekrobe
Copy link
Contributor

@pwinkler-ds great job! I fixed up a few small things to keep the schema working, please pull in the morning before you continue...

@petrvanekrobe
Copy link
Contributor

@moritzstaffel same here - rebase (making much nicer history) is clean here, do we want to keep the commits in main or squash? Thank you

@Verschwiegener
Copy link

(Shouldn't the Name of the Fixture "CIEColor" XML Element just be "Color" (https://github.com/mvrdevelopment/spec/blob/main/mvr-spec.md#table-26--fixture-node-childs)?

@Verschwiegener
Copy link

Verschwiegener commented May 2, 2024

The Symdef xsd Description also directly has the Geometry3D and Symbol Elements as its children instead of a ChildList which then has those Elements as Children (https://github.com/mvrdevelopment/spec/blob/main/mvr-spec.md#node-definition-symdef)

@petrvanekrobe
Copy link
Contributor

petrvanekrobe commented Jul 14, 2024

Matrix allows scientific notation, so the regex needs adjustment

    <xs:pattern value="(\{[+-]?(\d+([.]\d*)?([eE][+-]?\d+)?|[.]\d+([eE][+-]?\d+)?) *(,[+-]?(\d+([.]\d*)?([eE][+-]?\d+)?|[.]\d+([eE][+-]?\d+)?)*){2}\}){4}"/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants