Hotfix/validate command fail (#38)

* update validate customer journey

* bumbed up the version

ChangeLog

@@ -2,7 +2,7 @@ Ussd Airflow Changelog
 ================
 
 Version 0.0.1.5
-------------
+----------------
 Released on 15th Jan 2017
 
 Feature
@@ -11,3 +11,7 @@ Feature
 Enhancement
 - increased ussd maximum text to 500
 
+Version 0.0.1.6
+----------------
+Enhancement
+- validate_ussd_journey command to fail if customer journey fails validation

setup.py

@@ -1,6 +1,6 @@
 from setuptools import setup, find_packages
 
-__version__ = '0.0.1.5'
+__version__ = '0.0.1.6'
 
 setup(
     name='ussd_airflow',

ussd/management/commands/validate_ussd_journey.py

@@ -6,7 +6,7 @@
 
 
 class Command(BaseCommand):
-    help = 'Closes the specified poll for voting'
+    help = 'Validate ussd customer journey'
 
     def add_arguments(self, parser):
         parser.add_argument('ussd_configs', nargs='+', type=str)
@@ -31,5 +31,7 @@ def handle(self, *args, **options):
                 valid=is_valid,
                 error_message=error_ussd_config_message
             )
+            if not is_valid:
+                raise CommandError(json.dumps(error_message))
 
         self.stdout.write(json.dumps(error_message))

ussd/tests/test_commands.py

@@ -11,20 +11,21 @@ class ValidateCustomerJourneyConfig(TestCase):
 
     def test_command_output(self):
         out = StringIO()
-        file_name = "{0}/invalid_quit_screen_conf.yml".format(path)
+        file_name = "{0}/valid_quit_screen_conf.yml".format(path)
         call_command('validate_ussd_journey', file_name, stdout=out)
         expected_output = {
             file_name: dict(
-                valid=False,
-                error_message=dict(
-                    example_of_quit_screen=dict(
-                        text=['This field is required.']
-                    )
-                )
+                valid=True,
+                error_message=dict()
             )
         }
         self.assertDictEqual(expected_output, json.loads(out.getvalue()))
 
+    def testing_invalid_ussd_journey(self):
+        out = StringIO()
+        file_name = "{0}/invalid_quit_screen_conf.yml".format(path)
+        self.assertRaises(CommandError, call_command, 'validate_ussd_journey', file_name, stdout=out)
+
     def test_called_with_multiple_files(self):
         out = StringIO()
         file_1 = "{0}/valid_quit_screen_conf.yml".format(path)