Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on nightly numpy #3635

Closed
wants to merge 1 commit into from
Closed

Test on nightly numpy #3635

wants to merge 1 commit into from

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Feb 18, 2024

Don't merge

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b95d6d1) 98.58% compared to head (c8d5fde) 98.58%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3635   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          75       75           
  Lines       24706    24706           
=======================================
  Hits        24357    24357           
  Misses        349      349           

@rgommers
Copy link

Hi @mwaskom, since this is green that looks like a good sign. Can I ask if you know if recently released seaborn versions are compatible with NumPy 2.0?

@mwaskom
Copy link
Owner Author

mwaskom commented Apr 24, 2024

Ah, no, I put this up a while ago before realizing that there wasn’t actually a 2.0rc out yet. I don’t thing I ever succeeded in installing the new numpy here. Sorry for the confusion.

@mwaskom mwaskom closed this Apr 24, 2024
@rgommers
Copy link

Ah okay, thanks. There is an RC now. pip install numpy --pre should do it.

@mwaskom
Copy link
Owner Author

mwaskom commented Apr 24, 2024

Yep I’ve been tracking your issue, just have no bandwidth for seaborn right now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants