Dev - changed a lot, please double check! #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested against solr and fixed cloud/http clients. Started to comment. Added tests. Changed output behavior. Allowed child documents to be added. Sorted connections into own folder. Renamed response ns to converter. Added default connection to ease the use (reduce with-connection requirement).
Added tests which points out when you breakl something, but you will have to setup zk and solr for development now. Added docstrings and generated codox doc. Moved the connection ns into folder connections. Added and fixed support for childdocs. (PR: 16) Added and fixed support to create fq as hashmaps (PR: 12)
Added them back
changed to correct core
added the missing options to assoc
Added test for queries with fq.
|
Currently playing with Solr. Who knows what else I will find. As said might be a good way to leave it in dev branch some more time to see if everything works as expected! |
Solr uses maps for atomic updates, try to add normal clojure maps as values will cause an error. Just to not confuse new users I've changed the example in code and added a note in test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, last time I did not test against real Solr as already reported in #20. Changed to dev as this is a bigger change and I would like a 2nd person to watch over before move it to be master.
This one includes few other PRs: #18 #17 #16 #12 as I was changing mostly everything I've included and tested their ideas too.
The new tests will require a zk with solr running and will test basic functionality against them to be sure everything works fine! I'm sure a few more tests could be added maybe #14 could be an inspiration about this.