Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subshells to scripts #252

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Conversation

hernandezc1
Copy link
Collaborator

@hernandezc1 hernandezc1 commented Feb 28, 2025

Closes #240. Updates ZTF deployment scripts to address changes in #253

@troyraen
Copy link
Collaborator

Thanks for this, it will be very helpful! Can I ask you to make the directory reorg a separate PR? Since that one will touch a whole lot of files but will only rename them and not change the contents, making it separate will make things easier to review and to understand in the future when looking at the commit history. Here's how you can do that:

git switch develop
git pull
git switch -c u/ch/ztf/reorg  # or whatever you want to call the branch
git cherry-pick 007f27b
git push

Then open a new PR for that branch. Merge the new PR before merging this one. We ought to be able to do it quickly -- request my review and I'll make it a priority to look at. After that, I don't think that having commit 007f27b still in this PR will cause any problems, but if it does then I'll show you how to remove it.

@hernandezc1 hernandezc1 changed the title Organize Repo Directories Add subshells scripts Feb 28, 2025
@hernandezc1 hernandezc1 changed the title Add subshells scripts Add subshells to scripts Feb 28, 2025
@hernandezc1 hernandezc1 self-assigned this Feb 28, 2025
@hernandezc1 hernandezc1 added the Maintenance Maintain function or increase stability label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Maintain function or increase stability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a subshell when cding around in shell scripts
2 participants