Skip to content

2016.12.05. Version 2.3

Ivars Karpics edited this page Dec 7, 2016 · 70 revisions

Actions towards version 2.3

HardwareObject, Equipment

  • isReady(self) -> is_ready(self)
  • isConnected(self) -> is_connected(self)
  • getState(self) -> get_state(self)

Energy

  • abort(self) -> rename to stop()? Suggestion would be to use method stop for all hwobj

Resolution, ResolutionMockup

  • abort(self) -> rename to stop()?

Aperture

Create methods:

  • set_diameter_size_mm(self, float) maybe set_diameter_size_str ?
  • rename gget_diameter_size() -> et_diameter_size_mm()
  • get_diameter_size_list(self): returns list of floats, maybe return list of str?
  • set_position(self, str)
  • get_position(self): returns str (in ,out, beam)

Do we need a generic aperture or ApertureMockup is enough?

Slits

Rename existing and create new methods:

  • get_step_size(self): returns float
  • get_hor_gap_limits(self): returns (float, float)
  • get_ver_gap_limits(self): returns (float, float)
  • get_gaps_mm(self): returns (float, float), hor and ver
  • set_gaps_mm(self, hor_gap=None, ver_gap=None)
  • get_gaps_limits_mm(self): returns (float, float)
  • stop(self)

Do we need a GenericSlits or SlitsMockup is enought?

BeamInfo

Do we need a GenericBeamInfo or BeamInfoMockup is enough?

AbstractCollect

Methods called from queue_entry:

  • setMeshScanParameters(self, num_lines, num_images_per_line, mesh_range): mesh_range is list with two floats describing horizontal and vertical size of the grid. Should be changed to set_mesh_parameters
  • collect(self,owner, dc_parameters_list) -> maybe change to start_collect ?
  • stopCollect(self, owner)-> stop_collect exists, but should be changed in queue_entry. Or maybe rename to stop().
  • prepare_interleave(self, data_model, interleave_parameters)

Signals:

  • self.emit("collectNumberOfFrames", number_images=0, exposure_time=0): do we need this? It was used to initialize progressbar (set the maximum counts), but now a separate signal progressInit is doing that.

AbstractEnergyScan

Methods called from queue_entry.py

  • startEnergyScan(self, ) -> rename to start_energy_scan
  • doChooch(self, ) -> ** rename to do_chooch()**
  • cancelEnergyScan(self) -> maybe rename to stop()

To be continued...