Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including #37

Merged
merged 17 commits into from
Dec 10, 2023
Merged

Including #37

merged 17 commits into from
Dec 10, 2023

Conversation

jensens
Copy link
Member

@jensens jensens commented Dec 9, 2023 •
edited
Loading

New Feature to include other ini files.
Solves #5.

@jensens jensens marked this pull request as ready for review December 9, 2023 21:26
@jensens jensens requested a review from rnixx December 9, 2023 21:26
@rnixx
Copy link
Member

rnixx commented Dec 10, 2023

Maybe parsing.py would be a better module name instead of including.py.

@jensens
Copy link
Member Author

jensens commented Dec 10, 2023

Maybe parsing.py would be a better module name instead of including.py.

Confusing, its about including not parsing,

rnixx
rnixx reviewed Dec 10, 2023
View reviewed changes
src/mxdev/config.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rnixx rnixx merged commit 98c0c83 into main Dec 10, 2023
19 checks passed
@rnixx rnixx deleted the including branch December 10, 2023 15:28
@thet thet mentioned this pull request Dec 11, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnixx rnixx rnixx left review comments

Assignees
No one assigned
Labels
03 type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jensens @rnixx