Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'i' information icon next to each pool (LHS column) #435

Open
6 of 7 tasks
Tracked by #390
dospore opened this issue Jan 18, 2022 · 5 comments
Open
6 of 7 tasks
Tracked by #390

'i' information icon next to each pool (LHS column) #435

dospore opened this issue Jan 18, 2022 · 5 comments
Assignees

Comments

@dospore
Copy link
Contributor

dospore commented Jan 18, 2022

Add an 'i' icon which opens pool information onClick. Ignore net fees collected. All this information should be accessible through the PoolsStore and PoolContext, except for deployment date. This should be included in the fixed static pool info.

Show the below in pool info modal

  • Pool ticker
  • Price Feed - the 'new tab' icon opens the price feed oracle on Arbiscan in a new tab
  • Power Leverage
  • Collateral asset - the 'new tab' icon opens the collateral asset on Arbiscan in a new tab
  • Deployment date
  • Deployer address - the 'new tab' icon opens the deployer address on Arbiscan in a new tab
  • Keeper contract - the 'new tab' icon opens the keeper contract on Arbiscan in a new tab

Pool information designs: https://www.figma.com/file/Gh6WzO8gLZWDmTvRbw8ikm/Tracer-Style-Guide-%26-Components?node-id=5993%3A205928

Info icon designs (ignore the rest of the design this is only to show what the info icon should look like): https://www.figma.com/file/Gh6WzO8gLZWDmTvRbw8ikm/Tracer-Style-Guide-%26-Components?node-id=5635%3A196590

@dweberdev
Copy link
Contributor

Almost done with this story, just got a couple of questions:

  1. Link to price feed - I'm not able to find the correct address. There is a main, long and short contract address but they do not provide a price when opened on arbiscan. 
Example of a working address: https://arbiscan.io/token/0xf97f4df75117a78c1a5a0dbb814af92458539fb4


  2. Deployment date display - There is a “lastUpdated” value in the pools object but it does not match the date from this events link below. Any suggestions on how to get access to this value?
https://arbiscan.io/address/0x98C58c1cEb01E198F8356763d5CbA8EB7b11e4E2#events


  3. Net fees collected - Is this information displayed anywhere atm? I haven’t been able to find total primary/secondary fee and secondary receiver address.

Screen Shot 2022-01-19 at 6 29 17 PM

@chrdevmar
Copy link
Collaborator

chrdevmar commented Jan 21, 2022

  1. what are we expecting users to be linked to when they click through on the price feed? oracle wrapper contract on arbiscan?@issy-fleming @KittyLomas?

  2. fairly sure the only way to get this is to implement an api to find the contract deployment transactions for each of the pools. if we can cut it that would be good.

  3. we haven't been capturing this and probs not worth setting this up and backfilling for v1 at this stage

@ghost
Copy link

ghost commented Jan 21, 2022

  1. For v1.3, it makes sense to just point it to the oracle on arbitrum. But for V2, yes it should point to the oracle wrapper. We probably need to adjust the fields to correctly group the oracle + wrapper details, and then pool details.

  2. Cut it - will get the designs updated.

  3. Are all fee fields unattainable @ScaredIbis

@chrdevmar
Copy link
Collaborator

Are all fee fields unattainable @ScaredIbis

unfortunately yeah @issy-fleming we were never capturing them, have made appropriate changes to v2 contracts so that we log this information when commits are created/executed

@ghost
Copy link

ghost commented Jan 21, 2022

aight so for 1.3 fees are out of scope, but for 2.0 should be sweet? @ScaredIbis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants