Add Pool Details Modal #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for tracer-pools ready! 🔨 Explore the source changes: a424cd8 🔍 Inspect the deploy log: https://app.netlify.com/sites/tracer-pools/deploys/61ef3b424a856000087e8f80 😎 Browse the preview: https://deploy-preview-453--tracer-pools.netlify.app |
|
Following on from comments on #435
Otherwise, looks good to me Deployment date and fees were cut as per previous discussions. |
|
@dweberdev changes look good - happy with this on my end |
stevenbtc
approved these changes
Jan 24, 2022
stevenbtc
added a commit
that referenced
this pull request
Jan 31, 2022
* Portfolio routing * Add Pagination * Add Queued table * Style pagination * Add history and queued * Add v1 portfolio page * Style side nav * Add dummy data hook * Add basic tooltip * Change line colour * Put route in env var * Use committer_address in api * Remove unused * Update browse table type * Update table types * Update browse pools hook * Working save * Update headers * Update row structure * Add table colour * Reduce row sizing * Update data display * Add balancer pool prices * Update mint and burn button styling * Remove mint-burn page * Rename Browse to Pools * Merge summaries and buy/sell * Remove Browse from archetypes * Style mobile filter bars * Update filters * Fix build * Remove old route * Update effective gain * Small updates * Minor additions * Update bridge styling * Add logos * Add margin to top of modal * Make table with fixed widths * Align heights of modals * Keep border radius at md breakpoint * Change min amount for mint * Add initial upkeep load * Add past upkeeps * Add last rebalance base price change * Add denotion toggle * Fix application error * Update * Style denotion * Update * Remove unused * Add empty state * Add mobile filters * Add change in values to last rebalance * Add user balance * Display dash if 0 * User balance toFixed * Add tooltips * Add message for no change * Change numerical to number * Ensure side can be undefined * Update * Trim hook * Remove unused * Add skew farming teaser * Add tradeHistoryAPI draft * Add burn modals * Adjust nav breakpoints * Load trade history * Update * Update * Update * New portfolio nav * Update * Update and remove unused * Remove dummy account * Add Price by and Denoted in dropdowns * Add 'USDC' to the Portfolio Valuation section * Update queued table styles * Update trade history styles * Denoted in -> Denote in * Priced by -> Price by * Update * Update * Update * Set sig figs * Update * Update * Add API env var * Update * Update notional value * Only show the tokens that the user holds * Update * Update * Update * Update * Update * Update * Update * Update button hover states * Capitalise * Link to portfolio queued commits * Update formatDate * Update * Add historic data button * Remove pools footnote * Remove pools subtitle * Add sort by leverage to pools * Remove title row * Group pools by market * Remove unused * Update sections * Add headers * Add spot price * Add Reputation links * Add pool counts * Remove burn buttons * Update * Update * Update * Update * Update * Move market header inside pools table * Update * Remove view token link while queueing (#419) Remove view token link while queueing * Add Pool Details Modal (#453) * Add Pool Details Modal * Address PR comments and add link to price feed * Update icon color for light theme * Update follow link color for light theme Co-authored-by: Steven Yulong Yan <[email protected]> * Update * Add icons to market filter * Updated toasters to match designs * Update Co-authored-by: dospore <[email protected]> Co-authored-by: dweberdev <[email protected]>
dospore
added a commit
that referenced
this pull request
Jan 31, 2022
* Remove view token link while queueing (#419) Remove view token link while queueing * Add Pool Details Modal (#453) * Add Pool Details Modal * Address PR comments and add link to price feed * Update icon color for light theme * Update follow link color for light theme Co-authored-by: Steven Yulong Yan <[email protected]> * Use past upkeep balances for effective gain calc * Add pools-js * Remove logs Co-authored-by: dweberdev <[email protected]> Co-authored-by: Steven Yulong Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Display pool details to the user
Changes
Pending task: Price Feed - the 'new tab' icon opens the price feed oracle on Arbiscan in a new tab
Task #435