Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix php8.4 deprecated #177

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix php8.4 deprecated #177

merged 2 commits into from
Jan 14, 2025

Conversation

it-can
Copy link
Contributor

@it-can it-can commented Jan 13, 2025

Fixes

PHP Deprecated:  MyCLabs\Enum\PHPUnit\Comparator::formatEnum(): Implicitly marking parameter $enum as nullable is deprecated, the explicit nullable type must be used instead in ./myclabs/php-enum/src/PHPUnit/Comparator.php on line 46

@mnapoli
Copy link
Member

mnapoli commented Jan 14, 2025

Thanks! I fixed the build on master, could you rebase or merge it into this PR so that the build passes?

@it-can
Copy link
Contributor Author

it-can commented Jan 14, 2025

Thanks! I fixed the build on master, could you rebase or merge it into this PR so that the build passes?

done

@mnapoli mnapoli merged commit e7be269 into myclabs:master Jan 14, 2025
8 checks passed
@mnapoli
Copy link
Member

mnapoli commented Jan 14, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@it-can @mnapoli