Allow invalid tone #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conversion function to retrieve a boolean value from an environment variable.
environment variable REQUIRE_VALID_TONE specifies whether tones are strictly checked for valid entries. in some situations, the user may want to pass tones through that are not recognized by all supported targets.
if REQUIRE_VALID_TONE is False, then simply log a warning instead of raising an exception.
Log a warning if the user allows invalid tones by setting REQUIRE_VALID_TONE=0 in the env. This will help during troubleshooting to understand why codeplug files may not be valid.
Extend existing test_analog_weird_values to run with and without REQUIRE_VALID_TONES. If valid tones are not required, then assert that the channels were created with invalid tones.
Parametrize test_getenv_bool with various allowed, unknown, and default values.
Avoid issues where the value specified in the CSV uses a different case than expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #76 by allowing the user to specify
REQUIRE_VALID_TONE=0in the environment when generating the codeplug files.