Merge pull request #78 from myntra/revamp-select-input

Feature Update - Input Select
myntra · Oct 23, 2023 · d046267 · d046267
2 parents eae6063 + 5a3ec30
commit d046267
Showing 1 changed file with 20 additions and 14 deletions.
diff --git a/components/input-select/src/input-select.tsx b/components/input-select/src/input-select.tsx
@@ -273,27 +273,33 @@ export default class InputSelect<Value = any, Option = any> extends Component<
               onKeyDown={this.handleKeyDown}
               data-test-id="control"
             >
-              <div className={classnames('button')}>
-                {this.props.isLoading ? (
+              {this.props.isLoading ? (
+                <div className={classnames('button')}>
                   <Icon
                     className={classnames('state-icon')}
                     name={SpinnerSolid}
                     title="loading options"
                     spin
                     data-test-id="loading"
                   />
-                ) : (
-                  <Icon
-                    className={classnames('state-icon')}
-                    title={this.state.isOpen ? 'close' : 'open'}
-                    name={this.state.isOpen ? ChevronUpSolid : ChevronDownSolid}
-                    onClick={(event) =>
-                      this.state.isOpen && event.stopPropagation()
-                    }
-                    data-test-id="chevron"
-                  />
-                )}
-              </div>
+                </div>
+              ) : (
+                !this.props.value && (
+                  <div className={classnames('button')}>
+                    <Icon
+                      className={classnames('state-icon')}
+                      title={this.state.isOpen ? 'close' : 'open'}
+                      name={
+                        this.state.isOpen ? ChevronUpSolid : ChevronDownSolid
+                      }
+                      onClick={(event) =>
+                        this.state.isOpen && event.stopPropagation()
+                      }
+                      data-test-id="chevron"
+                    />
+                  </div>
+                )
+              )}
             </InputSelectControl>
           </div>
         )}