Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper Fix #82

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Stepper Fix #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5666da8
uikit icons fix
airishmyntra Nov 6, 2023
57e6547
test cases remove
airishmyntra Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,21 +57,21 @@ We provide a basic set of icons for immediate use, as well as the option to util
Run the following command using npm:

```bash
npm install @myntra/uikit-icons --save
npm install @applique-ui/uikit-icons --save
```
If you prefer Yarn, use the following command instead:

```bash
yarn add @myntra/uikit-icons
yarn add @applique-ui/uikit-icons
```

### Usage
1. Import any of the provided icons directly in your project:

```js
import BarsSolid from "@myntra/uikit-icons/svgs/BarsSolid"
import Bell from "@myntra/uikit-icons/svgs/Bell"
import BoxSolid from "@myntra/uikit-icons/svgs/BoxSolid"
import BarsSolid from "@applique-ui/uikit-icons/svgs/BarsSolid"
import Bell from "@applique-ui/uikit-icons/svgs/Bell"
import BoxSolid from "@applique-ui/uikit-icons/svgs/BoxSolid"
```

2. Pass this icon element as a prop to the component:
Expand Down
2 changes: 1 addition & 1 deletion components/accordion/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@applique-ui/uikit-context": "0.0.*",
"@applique-ui/icon": "0.0.*",
"@applique-ui/layout": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest",
"uikit-icons": "npm:@applique-ui/uikit-icons@latest",
"@applique-ui/uikit-utils": "0.0.*"
}
}
2 changes: 1 addition & 1 deletion components/avatar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"name-initials": "^0.1.3",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/badge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"dependencies": {
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest",
"uikit-icons": "npm:@applique-ui/uikit-icons@latest",
"@applique-ui/button": "0.0.*",
"@applique-ui/icon": "0.0.*"
}
Expand Down
2 changes: 1 addition & 1 deletion components/banner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@applique-ui/text": "0.0.*",
"@applique-ui/layout": "0.0.*",
"@applique-ui/icon": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest",
"uikit-icons": "npm:@applique-ui/uikit-icons@latest",
"@applique-ui/uikit-utils": "0.0.*"
}
}
2 changes: 1 addition & 1 deletion components/bread-crumb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
"dependencies": {
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/button-group/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"@applique-ui/dropdown": "0.0.*",
"@applique-ui/list": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
"@applique-ui/loader": "0.0.*",
"@applique-ui/uikit-context": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/click-away/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
"dependencies": {
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/dropdown/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
"@applique-ui/portal": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"prop-types": "^15.7.2",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/error-boundary/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"prop-types": "^15.7.2",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/fab/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@
"@applique-ui/dropdown": "0.0.*",
"@applique-ui/icon": "0.0.*",
"@applique-ui/button": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/field/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"prop-types": "^15.7.2",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/form/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@
"@applique-ui/input-file": "0.0.*",
"@applique-ui/uikit-context": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/grid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"prop-types": "^15.7.2",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/icon/example.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Icon from './src/icon'
import {Bell} from "@myntra/uikit-icons"
import {Bell} from "@applique-ui/uikit-icons"

# Icon

Expand Down
2 changes: 1 addition & 1 deletion components/icon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"react": "16.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/icon/src/icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import classnames from './icon.module.scss'
export type IconName = string | ReactNode

interface Props extends BaseProps {
/** icon component name from @myntra/uikit-icons */
/** icon component name from @applique-ui/uikit-icons */
name: IconName
/** Accessibility text for screen readers */
title?: string
Expand Down
2 changes: 1 addition & 1 deletion components/image/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
"@applique-ui/uikit-utils": "0.0.*",
"intersection-observer-polyfill": "^0.1.0",
"prop-types": "^15.7.2",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/input-checkbox/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/input": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/input-file/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
"@applique-ui/button": "0.0.*",
"@applique-ui/input-text": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/input-masked/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/input": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/input-month/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
"@applique-ui/input-masked": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"luxon": "^1.21.1",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/input-number/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/input": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/input-radio/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
"dependencies": {
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/input-select/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@
"@applique-ui/list": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"sifter": "^0.5.3",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/input-text-area/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
"@applique-ui/input": "0.0.*",
"@applique-ui/icon": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/input-text/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@
"@applique-ui/icon": "0.0.*",
"@applique-ui/input": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/input/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/icon": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/layout/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@
"peerDependencies": {},
"dependencies": {
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/list/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@
"@applique-ui/uikit-utils": "0.0.*",
"react": "^16.9.0",
"scroll-into-view-if-needed": "^2.2.20",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/loader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
"dependencies": {
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/measure/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
"@applique-ui/uikit-utils": "0.0.*",
"prop-types": "^15.7.2",
"resize-observer-polyfill": "^1.5.1",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/modal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@
"@applique-ui/portal": "0.0.*",
"@applique-ui/text": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/nav-bar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
"@applique-ui/click-away": "0.0.*",
"@applique-ui/uikit-context": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/page/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
"dependencies": {
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest"
"uikit-icons": "npm:@applique-ui/uikit-icons@latest"
}
}
2 changes: 1 addition & 1 deletion components/pagination/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"dependencies": {
"@applique-ui/uikit-can-i-use": "0.0.*",
"@applique-ui/uikit-utils": "0.0.*",
"uikit-icons": "npm:@myntra/uikit-icons@latest",
"uikit-icons": "npm:@applique-ui/uikit-icons@latest",
"@applique-ui/input-select": "0.0.*",
"@applique-ui/input-number": "0.0.*",
"@applique-ui/icon": "0.0.*",
Expand Down
16 changes: 13 additions & 3 deletions components/pagination/src/pages.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ import Icon from '@applique-ui/icon'

import ChevronLeftSolid from 'uikit-icons/svgs/ChevronLeftSolid'
import ChevronRightSolid from 'uikit-icons/svgs/ChevronRightSolid'

import ChevronSkipLeftSolid from 'uikit-icons/svgs/ChevronSkipLeftSolid'
import ChevronSkipRightSolid from 'uikit-icons/svgs/ChevronSkipRightSolid'

import { usePagination, DOTS } from './usePagination'
import classnames from './pagination.module.scss'

Expand Down Expand Up @@ -43,7 +47,13 @@ const SkipPages = ({ onPageChange, type, currentPage }) => {
onMouseOut={handleMouseOut}
>
{isHovering ? (
<Icon name={ChevronRightSolid} onClick={onSkipClick} />
<Icon
className={classnames('pages-icon')}
name={
type === DOTS.LEFT ? ChevronSkipLeftSolid : ChevronSkipRightSolid
}
onClick={onSkipClick}
/>
) : (
<span>&#8230;</span>
)}
Expand Down Expand Up @@ -102,7 +112,7 @@ const Pages = ({
>
<Icon
name={ChevronLeftSolid}
className={classnames('pages-item-icon', {
className={classnames('pages-icon', {
pagesItemIconDisabled: currentPage === 1,
})}
onClick={onPrevious}
Expand Down Expand Up @@ -131,7 +141,7 @@ const Pages = ({
})}
<Icon
name={ChevronRightSolid}
className={classnames('pages-item-icon', {
className={classnames('pages-icon', {
pagesItemIconDisabled: currentPage === lastPage,
})}
onClick={onNext}
Expand Down
19 changes: 10 additions & 9 deletions components/pagination/src/pagination.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,18 @@
&-item {
margin-left: 0 !important;

&-icon {
color: color('primary');
cursor: pointer;

&-disabled {
cursor: not-allowed;
}
}
&-skipPages {
&-skip-pages {
width: size('3x');
cursor: pointer;
}
}

&-icon {
color: color('primary');
cursor: pointer;

&-disabled {
cursor: not-allowed;
}
}
}
Loading
Loading