Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remember when order is auto exported #331

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

joerivanveen
Copy link
Contributor

@joerivanveen joerivanveen commented Jan 20, 2025

Deprecates audit functionality.

INT-799

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 96.59%. Comparing base (22c9e77) to head (52ec446).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Audit/Service/AuditService.php 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #331      +/-   ##
============================================
- Coverage     96.71%   96.59%   -0.12%     
- Complexity     1733     1734       +1     
============================================
  Files           322      322              
  Lines          5868     5874       +6     
============================================
- Hits           5675     5674       -1     
- Misses          193      200       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joerivanveen joerivanveen force-pushed the feat/remember-when-order-is-auto-exported branch from 454ec7f to 4f6311c Compare January 21, 2025 10:05
@joerivanveen joerivanveen marked this pull request as ready for review January 21, 2025 16:30
@joerivanveen joerivanveen requested a review from a team as a code owner January 21, 2025 16:30
@myparcel-bot myparcel-bot bot force-pushed the feat/remember-when-order-is-auto-exported branch 2 times, most recently from 10bb837 to e0c5b3b Compare January 22, 2025 09:14
Copy link
Contributor

@FreekVR FreekVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deze PR zou iig moeten benoemen dat de audits tabel gedropped wordt (in subject en/of body)

Daarnaast moeten alle Audit-gerelateerde classes en methods deprecated worden gemaakt (met @deprecated en/of deprecation errors waar toepasselijk)

De audit functionaliteit moet dan @deprecated Audits functionality will be removed in the next major release (oid) geven

Ik zag ook in de executeAutomatic method in PdkActionService nog een referentie naar een constant ui de audits class, kun je ook kijken of we die ergens anders door kunnen vervangen dan?

@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Jan 24, 2025
@joerivanveen
Copy link
Contributor Author

joerivanveen commented Jan 27, 2025

Deze PR zou iig moeten benoemen dat de audits tabel gedropped wordt (in subject en/of body)

Daarnaast moeten alle Audit-gerelateerde classes en methods deprecated worden gemaakt (met @deprecated en/of deprecation errors waar toepasselijk)

De audit functionaliteit moet dan @deprecated Audits functionality will be removed in the next major release (oid) geven

Ik zag ook in de executeAutomatic method in PdkActionService nog een referentie naar een constant ui de audits class, kun je ook kijken of we die ergens anders door kunnen vervangen dan?

De PR dropt de audits tabel niet, dat kan ook niet want dan zou je alle plugins meteen slopen. Ik heb @deprecated toegevoegd aan de audits funtionaliteit en de constanten verplaatst (good catch!).

@joerivanveen joerivanveen force-pushed the feat/remember-when-order-is-auto-exported branch from ce149e6 to 3707698 Compare January 27, 2025 07:06
@myparcel-bot myparcel-bot bot removed the changes requested (Auto) label Jan 27, 2025
@myparcel-bot myparcel-bot bot added the approved (Auto) label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

3 participants