Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom address and tax fields in blocks checkout #1191

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

EdieLemoine
Copy link
Member

@EdieLemoine EdieLemoine commented Nov 6, 2024

INT-599

@EdieLemoine EdieLemoine requested a review from a team as a code owner November 6, 2024 15:56
@EdieLemoine EdieLemoine force-pushed the feat/blocks-checkout-address-fields branch from 1a3f448 to 2560b79 Compare November 6, 2024 16:05
@EdieLemoine EdieLemoine force-pushed the feat/blocks-checkout-address-fields branch from 815236a to b983096 Compare November 8, 2024 15:48
Copy link

codecov bot commented Nov 8, 2024

❌ 19 Tests Failed:

Tests completed Failed Passed Skipped
245 19 226 0
View the top 3 failed tests by shortest run time
src/components/pdk/components.spec.ts DropOffInput > DropOffInput > emits update:modelValue event
Stack Traces | 0.004s run time
TypeError: Cannot destructure property 'component' of 'props.element' as it is undefined.
 ❯ Module.useDropOffInputContext ../../../node_modules/@.../src/composables/useDropOffInputContext.ts:18:22setup .../components/pdk/WcDropOffInput.vue:50:82callWithErrorHandling ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:200:19setupStatefulComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7811:25setupComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7772:36mountComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5122:7processComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5088:9patch ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:4617:11ReactiveEffect.componentUpdateFn [as fn] ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5232:11ReactiveEffect.run ../../../node_modules/@.../reactivity/dist/reactivity.cjs.js:226:19
src/components/pdk/components.spec.ts DropOffInput > DropOffInput > has prop element
Stack Traces | 0.005s run time
Error: No element found.
 ❯ Module.Je ../../../node_modules/@.../vue-form-builder/dist/index.js:106:11Module.generateFieldId ../../../node_modules/@.../utils/forms/generateFieldId.ts:9:89setup .../components/pdk/WcDropOffInput.vue:52:12callWithErrorHandling ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:200:19setupStatefulComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7811:25setupComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:7772:36mountComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5122:7processComponent ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5088:9patch ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:4617:11ReactiveEffect.componentUpdateFn [as fn] ../../../node_modules/@.../runtime-core/dist/runtime-core.cjs.js:5232:11
src/components/pdk/components.spec.ts Image > Image > has prop height
Stack Traces | 0.005s run time
AssertionError: expected { …(2) } to have property "height"
 ❯ ../../../node_modules/@.../src/common/runHasPropTest.ts:14:51

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Copy link
Contributor

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Als ik deze binnen haal werken een aantal dingetjes niet, o.a. de classic checkout gaat stuk (php warnings waardoor de pagina niet meer wordt weergegeven), maar ook in blocks + separate address fields, onthoudt hij de straat + nummer niet bijvoorbeeld, ligt dat aan mij?
  • Is het geen probleem dat Codecov zo tekeer gaat over de coverage? (Lokaal zie ik idd ook ‘maar’ 48% coverage voor de Hooks, bijv.)
  • Buiten dat, de code zelf vind ik super netjes, ook al kan ik ’m niet overal volgen :-)

src/PluginLoader.php Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Nov 12, 2024
@EdieLemoine EdieLemoine force-pushed the feat/blocks-checkout-address-fields branch from d1faf52 to 2ad2666 Compare November 15, 2024 13:43
@EdieLemoine
Copy link
Member Author

@joerivanveen het werkt nu wss een stuk beter, heb alleen nog niet alles kunnen nalopen, maar classic checkout zou het nu wel moeten doen en ook het adres synchroniseren met het adresregel 1 veld.

Dat met codecov moet ik nog ff uitzoeken, het is iets met het uploaden van de reports in de pipelines, gebeurt bij presta ook

@myparcel-bot myparcel-bot bot added the approved (Auto) label Nov 20, 2024
@EdieLemoine EdieLemoine force-pushed the feat/blocks-checkout-address-fields branch 3 times, most recently from 73aa94a to 61e56a5 Compare November 21, 2024 14:24
@myparcel-bot myparcel-bot bot force-pushed the feat/blocks-checkout-address-fields branch 2 times, most recently from b8ac478 to c3a744b Compare November 22, 2024 10:18
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 22, 2024

PDK upgrade summary

♻️ The following packages were upgraded (from cache):

Package Old version New version
@myparcel-pdk/admin 1.5.3 1.5.4
@myparcel-pdk/admin-component-tests 1.5.3 1.5.4
@myparcel-pdk/admin-preset-dashicons 1.5.3 1.5.4
@myparcel-pdk/admin-preset-default 1.5.3 1.5.4
@myparcel-pdk/app-builder 1.6.0 1.6.1
@myparcel-pdk/checkout 1.1.5 1.2.0
myparcelnl/pdk 2.45.0 2.47.2

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 22, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit 24dfdac
Logs https://github.com/myparcelnl/woocommerce/actions/runs/12013430332
Download https://github.com/myparcelnl/woocommerce/suites/31304826598/artifacts/2233803965

@myparcel-bot myparcel-bot bot force-pushed the feat/blocks-checkout-address-fields branch 4 times, most recently from a740396 to 98e4548 Compare November 25, 2024 09:49
@myparcel-bot myparcel-bot bot force-pushed the feat/blocks-checkout-address-fields branch from 98e4548 to 24dfdac Compare November 25, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

4 participants