-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MyTransportPJON.cpp #1526
Conversation
Enabling to define different value of PJON_POLLING_DURATION
Hi There, Please see #1520 Thx and br Eric. |
@Tico06 Hi Eric, Anyone with an idea what to try next? |
In the .ci folder there is a script which looks like the one which runs on Jenkins for Toll gate (STM32F1 - Tests): May be the sub function |
Hi There, |
@Tico06 Hi Eric, Now I need to convince @mfalkvidd to merge the PR #1528. I'm quite sure that the fix is Ok, because the issue is already fixed in the latest PJON repo. And my fix is doing the same. @gryzli133 It would be very nice and helpful if you could check the fix from PR #1528. Obviously you are using the PJON transport layer in your project. I'm sure your feedback will convince @mfalkvidd even more to merge PR #1528 into development. BR Immo |
Thanks a lot @virtual-maker to support ! How should I proceed ? copy/paste your update in my fork and commit ? Or a nicer way exist ? thx and br Eric. |
@Tico06 It would be nice, if you could give a comment in PR #1528 about Mikael's and my comment and how you see it to proceed. |
@Tico06 @gryzli133 @AdamSlowik Now you should rebase your PRs to latest mysensors/development. This will trigger the Toll gate again for your PR and we have to wait for the results. |
Enabling to define different value of PJON_POLLING_DURATION
Enabling to define different value of PJON_POLLING_DURATION