Fix mecab-python3 version #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mecab-python3 1.0.5 is from early 2022 and doesn't have 3.11 wheels. 1.0.9 is more recent and has wheels for all platforms. Also mecab-python3 was specified twice for some reason.
|
This also removes the double entry noted in #150. |
|
One of our repo is also receiving issues related to this. thanks @polm for providing the patch. ref: https://github.com/bolna-ai/bolna/issues/305 |
|
Also see #51 - mecab-python3 should be optional in this library, since not everyone is using Japanese. |
unok
pushed a commit
to unok/MeloTTS
that referenced
this pull request
Jul 10, 2024
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 23.12.1 → 24.4.2](psf/black@23.12.1...24.4.2) - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
blaisewf
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I am the maintainer of mecab-python3. Users of your library have been opening issues at my repo because they have trouble building MeCab. They should not have to build MeCab, but MeloTTS is using an old version of mecab-python3 that doesn't support recent Python versions. This raises the version. There are no functionality changes.