Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8129 list attachments on info request admin page #8130

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

8129 list attachments on info request admin page #8130

wants to merge 7 commits into from

Conversation

HelenWDTK
Copy link
Contributor

Relevant issue(s)

Fixes #8129

What does this do?

Adds attachment links on request admin page

Why was this needed?

To make it easier to see attachments per request

Implementation notes

Screenshots

Screenshot 2024-02-12 at 21 58 22 Screenshot 2024-02-12 at 21 58 42

Notes to reviewer

This will probably need fixing, but is a proof of concept

@HelenWDTK
Update info_request_helper.rb
e2d2dc7 
Collect attachments for an info request in one place
@HelenWDTK
Update show.html.erb
431b23d 
rendering attachments in the admin panel
@HelenWDTK
Create _some_attachments.html.erb
fb08a5b 
new partial to house none main body attachments
@HelenWDTK
Update info_request_helper.rb
134b3a3 
Add main body filtering and split method over several lines so as not to exceed 80 chars
@HelenWDTK HelenWDTK linked an issue Feb 12, 2024 that may be closed by this pull request
List attachments on info request admin page #8129
Closed
garethrees
garethrees requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@garethrees garethrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👏 I've left some suggestions to get this to the point of being mergeable. It's pretty close, so I think should be something you can have a crack at if you're interested. If not LMK and I can clean it up to get it over the line 🐎

app/views/admin_request/show.html.erb Outdated Show resolved Hide resolved
app/helpers/info_request_helper.rb Outdated Show resolved Hide resolved
app/views/admin_request/show.html.erb Show resolved Hide resolved
@HelenWDTK
Update info_request_helper.rb
368aabb 
undoing previous change
@HelenWDTK
Update show.html.erb
d055d6b 
Adds help block, and uses existing partial
@HelenWDTK
Update foi_attachment.rb
13b1136 
Adds scope to filter out main body part attachments out
@HelenWDTK
Copy link
Contributor Author

This works if we can live with the double heading. I don't get the changelog stuff, so will leave that to someone else if this seems ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethrees garethrees garethrees requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List attachments on info request admin page
2 participants
@HelenWDTK @garethrees