-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scorecards ]Added Year Comparison to Homepage #730
Draft
lucascumsille
wants to merge
17
commits into
2025-scorecards
Choose a base branch
from
year-comparison-homepage
base: 2025-scorecards
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d5cd17
to
5c51cbd
Compare
fa1985e
to
c85787f
Compare
5c51cbd
to
446843e
Compare
fceaeec
to
675c233
Compare
cba38d3
to
097b9c0
Compare
1828ebc
to
77437b6
Compare
17a6e1b
to
ec3e0ed
Compare
@struan I just finished pushing commit to this branch. It also included the latest feedback from CEUK, let me know if you need a walkthrough =) |
It uses Bootstrap large screen instead of random number.
- Improved layout on mobile so filters always use 2 items per row. - Advanced filters are now functional on mobile
- Instead of creating new classes it uses Bootstrap 5 default tooltip
ec3e0ed
to
e43e9a6
Compare
Allows for a bit less repetition in the templates
Much less code repetition. Also cut down on the number of templates included
Also do some removal of repeated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z-index-3
with Bootstrap 5 default classes. Same for 4 and 5#ff000c
color for the legendsscope
for cell are correctMobile