Improve date display on single speech page #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -245,7 +239,6 @@ $image-path: '../img' !default; | |||
| } | |||
|
|
|||
| .speech__meta-data__speaker-name { | |||
| margin-right: .5em; | |||
There was a problem hiding this comment.
Removal of this means that a speaker name and e.g. a date buttress against each other on e.g. /speeches.
There was a problem hiding this comment.
Ahh dammit, you're right @dracos. I didn't want to do it there – I wanted to zero the margin in .speech-single-speech .speech__meta-data__speaker-name. Will commit a fix right now.
|
Good setting out of things for translation :) If we don't need the spans (or at least their classes), it'd be good to drop them to make to simpler to see as a sentence for translation. Along with that, one bit of CSS that doesn't need reverting, and one bug I've spotted in the CSS changes, before this can be merged. |
dracos
force-pushed
the
issues/148-lost-speeches
branch
from
598de2e to
399ffb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for labour/conservative speech release (#148).