Using TLS without configuration #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on https://jira.mariadb.org/browse/MDEV-15935: first OK_Packet can contain variable `redirect_url` using "mariadb/mysql://[{user}[:{password}]@]{host}[:{port}]/[{db}[?{opt1}={value1}[&{opt2}={value2}]]]']" format. Signed-off-by: rusher <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
change redirection logging Signed-off-by: rusher <[email protected]>
Connector implementation of https://jira.mariadb.org/browse/MDEV-31855 Since MariaDB 11.4.1, TLS use has greatly been simplified. Connector side doesn't require TLS configuration anymore, even with self-signed certificates. connectors now validate ssl certificates using client password (using seed and server certificate SHA256 thumbprint). limitations: * only possible when using mysql_native_password/client_ed25519 authentication * password is required see https://mariadb.org/mission-impossible-zero-configuration-ssl/ Signed-off-by: rusher <[email protected]>
|
PR is based on #1499, because require OKPayload information, so depending on your review, it can change a lot :) (and this PR is clearly more important than PR redirection) |
Conflicts: .ci/config/config.compression+ssl.json .ci/config/config.compression.json .ci/config/config.json .ci/config/config.ssl.json azure-pipelines.yml src/MySqlConnector/Core/ConnectionPool.cs src/MySqlConnector/Core/ServerSession.cs src/MySqlConnector/Logging/Log.cs src/MySqlConnector/MySqlConnection.cs src/MySqlConnector/Protocol/Payloads/OkPayload.cs tests/IntegrationTests/RedirectionTests.cs tests/IntegrationTests/ServerFeatures.cs Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
bgrainger
reviewed
Jul 28, 2024
Signed-off-by: Bradley Grainger <[email protected]>
This can be executed concurrently by multithreaded tests. Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
This was a result of a bad merge. Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
bgrainger
reviewed
Jul 28, 2024
bgrainger
reviewed
Jul 28, 2024
Signed-off-by: Bradley Grainger <[email protected]>
bgrainger
reviewed
Jul 28, 2024
Refactor duplicated code in Ed25519AuthenticationPlugin. Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
bgrainger
reviewed
Jul 28, 2024
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
bgrainger
approved these changes
Jul 28, 2024
|
Fixed in 2.4.0; thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connector implementation of https://jira.mariadb.org/browse/MDEV-31855
Since MariaDB 11.4.1, TLS use has greatly been simplified.
Connector side doesn't require TLS configuration anymore, even with self-signed certificates.
Connectors can now validate ssl certificates using client password (using seed and server certificate SHA256 thumbprint).
limitations:
see https://mariadb.org/mission-impossible-zero-configuration-ssl/