Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea to work around Connection Lifetime that should have a similar effect. Related to #211.
This patch transforms
ClearPool
intoTrimPool
, and makesClearPool
= TrimPool(conectionsToKeep: 0);Then it adds a static method
MySqlConnection.TrimPool(int connectionsToKeep)
that should release only the required number of connections to keep the pool at some sane size without releasing more than required.Ideally, it would be better to trim connections based on lifetime, but I'm not confortable changing this codebase yet to add this. If it was possible to add some method like "TrimPool(TimeSpan)" that would trim based on idle time, I could easily implement the timer on the app side calling it every 3 minutes or so.