Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gimli v0.4 #163

Merged
merged 36 commits into from
Dec 19, 2024
Merged

Gimli v0.4 #163

merged 36 commits into from
Dec 19, 2024

Conversation

jordidj
Copy link
Collaborator

@jordidj jordidj commented Dec 4, 2024

PR description

Start of the pylbo submodule gimli, the General Interface for MPI-AMRVAC / Legolas Interconnection. Currently includes the automated generation of Legolas user files from SymPy expressions and the preparation of eigenvalue data for use with MPI-AMRVAC.

Pylbo

  • Submodule gimli.utils: utility functions for preparing Fortran writing.
  • Submodule gimli.equilibrium: functionality to define the equilibrium as SymPy expressions.
  • Submodule gimli.legolas: preparation of Legolas user files from an Equilibrium object.
  • Submodule gimli.amrvac: preparation of Legolas eigenvalue data for use with MPI-AMRVAC.

Checklist

  • all tests pass (and for new features, new tests are added)
  • documentation has been updated (if applicable)

Repository owner deleted a comment from UdokaValentine Dec 18, 2024
@jordidj
Copy link
Collaborator Author

jordidj commented Dec 18, 2024

Unsure why the new test is failing. It passes for me locally. Maybe some difference due to operating systems?

Edit: it is passing on MacOS, failing on Ubuntu. Will have to regenerate test file on Ubuntu

@jordidj jordidj merged commit 688b059 into develop Dec 19, 2024
8 checks passed
@jordidj jordidj deleted the gimli branch December 19, 2024 08:13
@jordidj jordidj restored the gimli branch December 19, 2024 08:13
@jordidj jordidj deleted the gimli branch December 19, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants