Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions to Pylbo mode visualisation #164

Open
wants to merge 74 commits into
base: develop
Choose a base branch
from
Open

Extensions to Pylbo mode visualisation #164

wants to merge 74 commits into from

Conversation

nicolasbrughmans
Copy link
Contributor

@nicolasbrughmans nicolasbrughmans commented Jan 22, 2025 •
edited
Loading

PR description

New features

Pylbo

  • Plotting modes for multiple datasets (e.g. at different wavenumbers)
  • Plotting of streamlines of v and B
  • Plotting of vector fields of v and B
  • Plotting of background velocity in animations
  • Load series can sort on parameter

Bugfixes

Pylbo

  • Small fixes in plotting routines
  • Gimli: gravity can be non-constant

Checklist

  • all tests pass (and for new features, new tests are added)
  • documentation has been updated (if applicable)

@nicolasbrughmans
Two fixes to make it work on my machine
02b6fc3
@nicolasbrughmans
Legolas version before refactor
243b3d9
@nicolasbrughmans
Merge branch 'develop' of https://github.com/n-claes/legolas into dev…
ff2df5b 
…elop
@nicolasbrughmans
Merge branch 'develop' of https://github.com/n-claes/legolas into dev…
1aec46d 
…elop
@nicolasbrughmans
Merge branch 'develop' of https://github.com/n-claes/legolas into dev…
17cb7b2 
…elop
@nicolasbrughmans
pylbo: bugfix calculating ef resonances
3ef590c
@nicolasbrughmans
Merge branch 'develop' of https://github.com/n-claes/legolas into dev…
7c9c21d 
…elop
@nicolasbrughmans
Merge branch 'develop' of https://github.com/n-claes/legolas into vis…
9d7039c 
…_nico
@nicolasbrughmans
Bugfix: get_omega_max in range
4de4f16
@nicolasbrughmans
Pylbo: Lagrangian dot in animations
9d62dca
@nicolasbrughmans
Merge branch 'vis_nico' of https://github.com/nicolasbrughmans/legolas …
705f14f 
…into vis_nico
@nicolasbrughmans
Control wavenumber textbox
4d08c9a
@nicolasbrughmans
Bugfix
b8979e4
@nicolasbrughmans
Merge branch 'vis_nico' of https://github.com/nicolasbrughmans/legolas …
c94ec3f 
…into vis_nico
@nicolasbrughmans
Less printing to speed up animation making
eb89005
@nicolasbrughmans
pylbo: support mode visualisation for dataseries
3d0843f
@nicolasbrughmans
pylbo: 1d temporal visualisation for dataseries
5f9574b
@nicolasbrughmans
Merge branch 'vis_nico' of https://github.com/nicolasbrughmans/legolas …
271386d 
…into vis_nico
@nicolasbrughmans
pylbo: 2p plotting supports dataseries
bf4a75f
@nicolasbrughmans
pylbo: 3d and vtk support dataseries
784201e
@nicolasbrughmans
pylbo: comoving dots only for y-direction
6f2f24a
@nicolasbrughmans
pylbo: 2d streamline functionality
4fc60be
@nicolasbrughmans
pylbo: 2d vectorplots for streamlines and quivers
79a894e
@nicolasbrughmans
pylbo: bugfix comoving dot polar
560a7ae
@nicolasbrughmans
black formatting
fd993ad
@nicolasbrughmans
formatting
60d2916
@nicolasbrughmans
Merge branch 'small_matrix_elements' of https://github.com/nicolasbru…
903d339 
…ghmans/legolas into vis_nico
@nicolasbrughmans
pylbo: resonance test removed keyword
6f7f938
@nicolasbrughmans
pylbo: no automatic Lagrangian dots in animation
44be1c2
@nicolasbrughmans
pylbo: 3d explicitly doesn't support animation
18e067e
@nicolasbrughmans
docs: confusing lists on ford main page
8881ef2
@nicolasbrughmans
pylbo: ef_name validation for DataSeries
a626863
@nicolasbrughmans
pylbo: avoiding circular import
fda2890
@nicolasbrughmans
pylbo: align mode ef panel
720aded
@nicolasbrughmans
Merge branch 'develop' of https://github.com/n-claes/legolas into vis…
53242ec 
…_nico
@nicolasbrughmans
support for varying gravity
b20cf51
@nicolasbrughmans
throw error if datfile not found
b4a2174
@nicolasbrughmans
flake8 formatting
597bd4a
@nicolasbrughmans
docs: typo
4cedfdc
@nicolasbrughmans
Revert accidental push of "Derived efs for gas and magnetic pressure"
ef20822 
This reverts commit da3e61e.
@nicolasbrughmans
Revert accidental push of "Derived efs: updated testing"
f8376e8 
This reverts commit 31915bd.
@nicolasbrughmans
pylbo: dataseries input checked in ModeVisualisationData
a9f0bbc
@nicolasbrughmans
tests viz modes from dataseries
b7f0230
@nicolasbrughmans
style: removed unused packages
7aa51cf
@nicolasbrughmans
testing background flow dots
6b8b161
@nicolasbrughmans
testing 2D vectorplots
e92b20e
@nicolasbrughmans
avoid excessive logging
c27d95a
@nicolasbrughmans
backgrounds not supported for derived efs
367cefb
@nicolasbrughmans
pylbo: load_series can sort on parameter
27f609f
@nicolasbrughmans
test function is_custom_grid
15bd97f
@nicolasbrughmans
style: removing unused definitions
9af21a7
@nicolasbrughmans
style
b390dd0
@nicolasbrughmans
testing streamlines modes
5580449
@nicolasbrughmans
Copy link
Contributor Author

Making sure the final tests work now. Let me know if you have any suggestions for additional tests or to clean up the commit history!

@nicolasbrughmans nicolasbrughmans force-pushed the vis_nico branch 2 times, most recently from c0f2f22 to 5b74deb Compare January 23, 2025 15:00
@nicolasbrughmans nicolasbrughmans marked this pull request as ready for review January 24, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicolasbrughmans