Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iroh provide is now iroh start #31

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix: iroh provide is now iroh start #31

merged 1 commit into from
Aug 24, 2023

Conversation

Frando
Copy link
Member

@Frando Frando commented Aug 24, 2023

I think this is needed to have netsim pass after n0-computer/iroh#1356 is merged.
@Arqu is there a good way to test this beforehand?

@Frando Frando requested a review from Arqu August 24, 2023 17:12
@Arqu
Copy link
Collaborator

Arqu commented Aug 24, 2023

Yes! on the iroh repo for the PR that needs it run with /netsim branch changes-for-1356 and you should run against this branch. It will then run and be available in the Actions tab. After that feel free to merge.

@Arqu
Copy link
Collaborator

Arqu commented Aug 24, 2023

This passed in https://github.com/n0-computer/iroh/actions/runs/5967160210 so I'm going to merge.

@Arqu Arqu merged commit 494d502 into main Aug 24, 2023
1 check failed
@Arqu Arqu deleted the changes-for-1356 branch August 24, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants