refactor!: extract RPC definitions into here #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
added a commit
to n0-computer/iroh
that referenced
this pull request
Oct 30, 2024
dignifiedquire
added a commit
to n0-computer/iroh
that referenced
this pull request
Oct 31, 2024
# Conflicts: # Cargo.lock
rklaehn
changed the title
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-docs/pr/5/docs/iroh_docs/ Last updated: 2024-11-13T09:47:12Z |
it is not better or worse than the new one, but it breaks less code
dignifiedquire
commented
Nov 12, 2024
src/lib.rs
Outdated
| @@ -48,6 +48,9 @@ mod ticket; | |||
| #[cfg(feature = "engine")] | |||
| #[cfg_attr(iroh_docsrs, doc(cfg(feature = "engine")))] | |||
| pub mod engine; | |||
| #[cfg(feature = "engine")] | |||
| #[cfg_attr(iroh_docsrs, doc(cfg(feature = "engine")))] | |||
There was a problem hiding this comment.
this should be featurerpc
dignifiedquire
commented
Nov 12, 2024
dignifiedquire
commented
Nov 12, 2024
dignifiedquire
commented
Nov 12, 2024
dignifiedquire
commented
Nov 12, 2024
dignifiedquire
commented
Nov 12, 2024
dignifiedquire
commented
Nov 12, 2024
|
some small things, otherwise LGTM |
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Nov 13, 2024
Depends on n0-computer/iroh-docs#5 --------- Co-authored-by: Diva M <[email protected]> Co-authored-by: Ruediger Klaehn <[email protected]>
matheus23
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Nov 14, 2024
Depends on n0-computer/iroh-docs#5 --------- Co-authored-by: Diva M <[email protected]> Co-authored-by: Ruediger Klaehn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the rpc types and handler to docs, from iroh.
Really, this does add the rpc types and handler to docs, from iroh! Two lines to make check-cc happy.
Breaking changes:
spawn now takes 7 parameters instead of 6
Note:
I reverted the author_default() thing. Not that there was anything wrong with this, but I think breaking less code is good.