forked from quinn-rs/quinn
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ignore] testing CI #22
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux drops UDP datagrams larger than 64k, even when segmented. In other words, 64k - headers is the maximum GSO payload size.
This uses Apple's private sendmsg_x and recvmsg_x system calls for multi-packet UDP I/O.
This makes it more apparent that this logging is happening because users are more likely to read at least the first "layer" of the APIs they are using. In addition, we are going to offer a `try_send` API which requires us to decouple the `send` free-function from this logging behaviour.
This allows us to have it follow the exact same implementation as the unix and windows one.
`quinn-udp` depends on the `windows-sys` crate, more specifically `windows_sys::Win32::Networking::WinSock`: https://github.com/quinn-rs/quinn/blob/a5d9bd1154b7644ff22b75191a89db9687546fdb/quinn-udp/src/cmsg/windows.rs#L6 https://github.com/quinn-rs/quinn/blob/a5d9bd1154b7644ff22b75191a89db9687546fdb/quinn-udp/src/windows.rs#L13 Previously `quinn-udp` was using `windows-sys` `v0.52`. quinn-rs#1960 updated `quinn-udp` to `v0.59`. Note that `windows-sys` went straight from `v0.52` to `v0.59`. There are no versions in between. `quinn-udp` does not depend on any `windows-sys` `v0.59` features. In other words, it can support both `windows-sys` `v0.52` and `v0.59`. https://github.com/microsoft/windows-rs/releases/tag/0.59.0 This commit allows downstream users of `quinn-udp` to explicitly use `quinn-udp` with `windows-sys` `v0.52`. For other users not explicitly demanding `windows-sys` `v0.52`, cargo will choose `windows-sys` `v0.59`: > It also attempts to use the greatest version currently available within that compatibility range. https://doc.rust-lang.org/cargo/reference/resolver.html#semver-compatibility
Updates the requirements on [rustls-platform-verifier](https://github.com/rustls/rustls-platform-verifier) to permit the latest version. - [Release notes](https://github.com/rustls/rustls-platform-verifier/releases) - [Changelog](https://github.com/rustls/rustls-platform-verifier/blob/main/CHANGELOG) - [Commits](rustls/rustls-platform-verifier@v/0.3.0...v/0.3.4) --- updated-dependencies: - dependency-name: rustls-platform-verifier dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
A header and tag could easily be larger than 40 bytes.
This gives the proto state the ability to be externally notified about network path changes it might not be aware off. In this case it will re-set the RTT, Congestion Controller and MTU settings to the initial states based on the TransportConfig. This addresses the quinn-proto part of quinn-rs#2018.
Updates the requirements on [thiserror](https://github.com/dtolnay/thiserror) to permit the latest version. - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.21...1.0.69) --- updated-dependencies: - dependency-name: thiserror dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
quic_proto::frame::Type should be publically re-exported. This commit renames the it to a name more befitting of a public type.
Temporarily revert a5d9bd1 because it introduced semver-incompatible change. Will submit as a PR again after merging.
matheus23
force-pushed
the
matheus23/update-cc
branch
from
November 15, 2024 08:09
dbba182
to
5d4a735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.