Gradle 8.7 works with configuration cache #232
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
|
Sorry for just dropping this without explanation. Had some spare time and played around with it. Just wanted to not loose my thoughts. I wasn't confident if i'm understanding the gradle lifecylcle enough to be able to change it without breaking current behaviour. A major blocker was that gradle doesn't allow the side effects of using jgit in the configuration phase to detect the .git-folder. Maybe it would be ok to use a simpler algorithm to detect the presence of a repo without instanciating via jgit? Maybe just checking the presence of a not empty .git-folder is enough? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First try to make in compatible with configuration cache in gradle 8.7. Further refactoring needed.
Changes: Detection of .git-dir not possible during configration phase -> Logic of GitDirLocator without usage of jgit?