-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors task's inputs to support configuration cache for modern Gradle versions #235
base: master
Are you sure you want to change the base?
Conversation
…radle versions Breaks backward compatibility: The locations of the .git directory is not searched up the directory tree automatically anymore.
How was it tested? Provide examples please of running the snapshot version with no error and clearly enabled configuration cache |
I created this project https://github.com/igormukhin/gradle-git-properties-demo to test the changes. The test can replicated by this:
The configuration cache is enabled by default in
Any ideas about how to automate the test are welcome. |
Thank you for your contribution! I’ll need a bit of time to review it thoroughly, as I’d like to refresh myself on some of the implementation details. I’ll get back to you soon! |
After (if) the PR gets merged, we can think about upgrading the Gradle version of the project. By that:
|
@tha2015 I think I see one of the main maintainers here. Sorry for off-top but the project was updated last time in 05.2022 - more than 2 years ago. It's very far from the recent Gradle and I'm pretty sure it might have some issues with recent Gradle versions. My point is, Spring refers it in the docs, people use it but they do not have updates. Can we clarify the status of the project? We have a project here that was cloned and changed about a year ago so it supports Gradle CC. Maybe it's time to refine and switch to the new plugin for Spring references |
@artemptushkin You’re absolutely right; the project hasn’t been actively maintained for a while, and to ensure its long-term sustainability, we’ll likely need new contributors—assuming there’s still interest from the community. Unfortunately, @n0mer hasn’t been active recently, so while I can assist with merging and publishing updates, I don’t currently have access to adjust project settings or facilitate ownership transfer. Moving forward, it’s really up to us as a community to decide if we’d like to keep it going or let it go. |
Hi everyone, please let me know if you'd like me to merge and publish an RC (release candidate) version. |
100% |
This PR solves #225.
About the changes:
.git/config
,.git/HEAD
,.git/refs/**
Drawback: This PR also introduces a minor backward incompatibility. The location of the .git directory is not searched up the directory tree automatically anymore. The git directory has to be set explicitly with
dotGitDirectory
property.Reasoning:
To assist the user who migrated to the new plugin version, he will see the helpful error message:
No Git repository found. Ensure the gitProperties.dotGitDirectory property points to the correct .git directory.