Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rippleBorder #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added rippleBorder #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export default class Ripple extends PureComponent {
rippleCentered: false,
rippleSequential: false,
rippleFades: true,
rippleBorder: true,
disabled: false,

onRippleAnimation: (animation, callback) => animation.start(callback),
Expand All @@ -40,6 +41,7 @@ export default class Ripple extends PureComponent {
rippleCentered: PropTypes.bool,
rippleSequential: PropTypes.bool,
rippleFades: PropTypes.bool,
rippleBorder: PropTypes.bool,
disabled: PropTypes.bool,

onRippleAnimation: PropTypes.func,
Expand Down Expand Up @@ -232,6 +234,7 @@ export default class Ripple extends PureComponent {
rippleCentered,
rippleSequential,
rippleFades,
rippleBorder,

...props
} = this.props;
Expand Down Expand Up @@ -260,6 +263,7 @@ export default class Ripple extends PureComponent {

let containerStyle = {
borderRadius: rippleContainerBorderRadius,
overflow: rippleBorder ? 'hidden' : 'visible',
};

return (
Expand Down
1 change: 1 addition & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ class Example extends Component {
rippleCentered | Ripple always starts from center | Boolean | false
rippleSequential | Ripple should start in sequence | Boolean | false
rippleFades | Ripple fades out | Boolean | true
rippleBorder | Ripple respects border of parent | Boolean | true
disabled | Ripple should ignore touches | Boolean | false
onPressIn | Touch moved in or started callback | Function | -
onPressOut | Touch moved out or terminated callback | Function | -
Expand Down
1 change: 0 additions & 1 deletion styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const styles = StyleSheet.create({
...StyleSheet.absoluteFillObject,

backgroundColor: 'transparent',
overflow: 'hidden',
},

ripple: {
Expand Down